Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for GH #408 PackageRecord error #409

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

maresb
Copy link
Contributor

@maresb maresb commented May 18, 2023

I'm not sure what's causing #408 but I want to write a test so we can check when it's solved.

@maresb maresb requested a review from a team as a code owner May 18, 2023 20:39
@netlify
Copy link

netlify bot commented May 18, 2023

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit 8961573
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/65318d93a7004d000867d6f5
😎 Deploy Preview https://deploy-preview-409--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ogrisel
Copy link

ogrisel commented Oct 19, 2023

I recently observed the KeyError for the __osx package when running a conda-lock with recent mamba & conda installed on my system.

I contributed a fix to the upstream repo that works for me:

I am not sure if this is related to this or not.

/cc @lesteve.

@maresb
Copy link
Contributor Author

maresb commented Oct 19, 2023

Ah, bad news, but thanks for letting us know. Also thanks for submitting the upstream fix! And also for raising visibility on this PR which I meant to merge.

@maresb
Copy link
Contributor Author

maresb commented Oct 19, 2023

@ogrisel, can you share your environment.yml file which led to the error?

@maresb maresb merged commit c2975fe into conda:main Oct 19, 2023
10 checks passed
@ogrisel
Copy link

ogrisel commented Oct 20, 2023

@maresb here is the command I used:

conda-lock lock --mamba --kind explicit --platform osx-64 --file build_tools/azure/pylatest_conda_forge_mkl_osx-64_environment.yml --filename-template build_tools/azure/pylatest_conda_forge_mkl_osx-64_conda.lock

and here is the content of pylatest_conda_forge_mkl_osx-64_environment.yml:

channels:
  - conda-forge
dependencies:
  - python
  - numpy
  - blas[build=mkl]
  - scipy
  - cython
  - joblib
  - threadpoolctl
  - matplotlib
  - pandas
  - pyamg
  - pytest
  - pytest-xdist=2.5.0
  - pillow
  - setuptools
  - pytest-cov
  - coverage
  - ccache
  - compilers
  - llvm-openmp

@lesteve
Copy link
Contributor

lesteve commented Oct 20, 2023

For the record this command runs fine for me on a Linux machine (conda 23.9.0 mamba 1.5.2 which are the latest releases at the time of writing), so maybe the issue only happens when running the command on an OSX machine?

@maresb maresb deleted the git-test branch October 20, 2023 08:33
@ogrisel
Copy link

ogrisel commented Oct 20, 2023

Yes I believe that this might be because the __osx virtual package does not show up on a Linux host.

This is probably a bug of mamba or conda that ignores the --platform osx-64 argument when defining the system specific virtual packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants