Fix support for the PackageType.VIRTUAL_SYSTEM enum

[ogrisel]

While trying to use conda-lock with the latest conda and mamba on scikit-learn, I got errors due to the use of recently introduced conda.models.enums.PackageType.

Here is a PR to attempt to fix it while preserving backward compat.

Probably fixes: #2129, #1794, #1770.

[ogrisel]

Note: since some of the linked issues are really old. The commit in conda that introduced the PackageType.VIRTUAL_SYSTEM enum is 4 years old. So maybe it has always been an enum rather than a string and the backward compat protection in my PR is useless:

• conda/conda@f32904b#diff-644cb77c5dfe960eaf19f671faeb8be302421c716051bb4b4e083299951f5eb5R132

[jonashaag]

Thanks for the PR! I haven't reviewed the changes so far but can you add tests for that reproduce the bugs (in the unfixed version)?

[ogrisel]

I am not sure how to craft a minimal reproducer from the linked issues that wouldn't require access to the network and I am not familiar with how you write tests for this project.

Would you prefer a minimal unit test? Or an integration test, for instance for the case reported in #1770 using check_output in test_all.py?

[jonashaag]

Any test is fine really. We have lots of tests that need the network.

[ogrisel]

I am having trouble setting up a dev environment for mamba following the instructions found here: https://mamba.readthedocs.io/en/latest/developer_zone/build_locally.html:

$ mamba env create --name mambadev --file ./mamba/environment-dev.yml
...
Installing collected packages: securesystemslib
Successfully installed securesystemslib-0.30.0

done
Unable to install package for sel(win).

Please double check and ensure your dependencies file has
the correct spelling.  You might also try installing the
conda-env-sel(win) package to see if provides the required
installer.

EDIT: will comment out line - sel(win): winreg and try again. But later.

[ogrisel]

@jonashaag I have pushed a test. I am could not get my test setup to actually use my dev mamba/mamba/utils.py (even when following the instructions of the contributor guide), it would still use the mamba/mamba/utils.py from my miniforge3/lib/python3.10/site-packages for some reason.

Still I think the PR contents is working as intended and hopefully your CI can confirm this.

[jonashaag]

Perfect thank you! Would you mind also adding a Linux test? Could be a copy paste or a parameteized test

[ogrisel]

Could be a copy paste or a parameterized test

@jonashaag I updated the test to parameterize it for Linux and Windows (in addition to macOS).

[AntoinePrv]

Thanks for this ! It should also be backported to the 1.x branch if you want to see it a 1.5.3 release (not planned for now).

[JohanMabille]

Thanks for the fix @ogrisel ! We should fix the build before backporting it.

[ogrisel]

Indeed, I hardcoded the use of bash because the tests was originally written only for macOS. Now that it was parameterized for windows, we need to unhardcode the shell. I will do a follow-up PR.

[ogrisel]

@jonashaag @AntoinePrv @JohanMabille hopefully #2924 should fix the Windows CI.