Removes quantity getter in Stripe::Subscription #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @rmarronnier - Good catch! |
rmarronnier
added a commit
to rmarronnier/stripe.cr
that referenced
this pull request
Jul 11, 2021
stephendolan
pushed a commit
that referenced
this pull request
Jul 11, 2021
* Updates * Code review (typos + comments) * Removed quantity getter in Stripe::Subscription (#28) * Bump actions/cache from 2.1.5 to 2.1.6 (#29) * Adds Stripe::File and Stripe::FileLink (#32) * file + file_link classes * Add retrieve methods and specs * Readme update * Adds Stripe::Account (#31) * Stripe::Account class. Needs to be reviewed for nillable types * WIP - refactoring Address * Complete Account object * Added working spec * Merge Adress and AdressJP * Adds Event object and Webhook class (#26) * Adds Event object + spec * WIP - Adding Webhook class / methods / specs * WIP - needs proper new Error objects * Webhook methods tested and updated. * Fixed ameba style verbose warning in webhook * WIP on macroization * cleanup * webhook security specs * Better event spec + previous_attributes field * Added annotations + respective macros * Stripe::Account union fields Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to pull and create a
Stripe::Subscriptionfrom json payload, I got a parsing error :Missing JSON attribute: quantity\n parsing Stripe::Subscription at line 1, column 1The json is correct wrt https://stripe.com/docs/api/subscriptions/object , the Stripe::Subscription object has only a quantity key buried in the item sub object.