Adds Stripe::Account #31
Conversation
|
@rmarronnier, I know this is just a draft, but just curious after looking a bit in the code. Do we need to have a specific Address class for the Japanese addresses? I think Crystal can handle it fine anyway? Or is it for any other reason? |
|
Good question : the difference between a standard address and japanese one in a Stripe context is the We could have a single Stripe::Address with a nillable It was maybe too zealous on my part to create two different classes :-) |
I'm not convinced anymore the
Working spec written.
I'm done with it. Ready for review :-) |
* Stripe::Account class. Needs to be reviewed for nillable types * WIP - refactoring Address * Complete Account object * Added working spec * Merge Adress and AdressJP
* Updates * Code review (typos + comments) * Removed quantity getter in Stripe::Subscription (#28) * Bump actions/cache from 2.1.5 to 2.1.6 (#29) * Adds Stripe::File and Stripe::FileLink (#32) * file + file_link classes * Add retrieve methods and specs * Readme update * Adds Stripe::Account (#31) * Stripe::Account class. Needs to be reviewed for nillable types * WIP - refactoring Address * Complete Account object * Added working spec * Merge Adress and AdressJP * Adds Event object and Webhook class (#26) * Adds Event object + spec * WIP - Adding Webhook class / methods / specs * WIP - needs proper new Error objects * Webhook methods tested and updated. * Fixed ameba style verbose warning in webhook * WIP on macroization * cleanup * webhook security specs * Better event spec + previous_attributes field * Added annotations + respective macros * Stripe::Account union fields Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
WIPStripe::Account is a big baby
which might need some refactoring (I've started with Stripe::Address which was the same as Shipping::Address) if we don't want a 300+ LOC file (and most importantly if some types are shared with other Stripe objects)which might be refined as we further implement Stripe Connect and test it live.No specs / not working yetEDIT : Ready for review