Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable bytes and string data types for max/min udaf #8913

Closed
jnh5y opened this issue Mar 21, 2022 · 4 comments
Closed

Enable bytes and string data types for max/min udaf #8913

jnh5y opened this issue Mar 21, 2022 · 4 comments
Assignees
@bvarghese1
Labels
enhancement streaming-engine Tickets owned by the ksqlDB Streaming Team user-defined-functions Tickets about UDF, UDAF, UDTF

Comments

@jnh5y
Copy link
Member

jnh5y commented Mar 21, 2022

Is your feature request related to a problem? Please describe.
The mentioned functions only require that types by Comparable. Presently, they do not support BYTES or the time types.

Describe the solution you'd like
Add support for BYTES and time types to MAX, MIN, TopKDistinct, GREATEST, and LEAST

Additional context
Add any other context or screenshots about the feature request here. is about handling TopK for these types and DECIMAL.
@jnh5y jnh5y added enhancement needs-triage user-defined-functions Tickets about UDF, UDAF, UDTF streaming-engine Tickets owned by the ksqlDB Streaming Team labels Mar 21, 2022
@jnh5y
Copy link
Member Author

jnh5y commented Apr 26, 2022

#8924 / #8757 adds support for the time types to Max and Min!

@bvarghese1 bvarghese1 self-assigned this Apr 26, 2022
@jnh5y jnh5y mentioned this issue Apr 28, 2022
Merged
2 tasks
@suhas-satish
Copy link
Member

@bvarghese1 , can this be closed?

@bvarghese1
Copy link
Member

I fixed it only for min and max udafs. Need to check for TopKDistinct, GREATEST, and LEAST

@jnh5y jnh5y changed the title Add support for BYTES and time types to MAX, MIN, TopKDistinct, GREATEST, and LEAST Enable bytes and string data types for max/min udaf May 16, 2022
@jnh5y
Copy link
Member Author

jnh5y commented May 16, 2022

As some housekeeping, I added a new issue: #9125 for the remaining work so that we can close this issue.

@jnh5y jnh5y closed this as completed May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvarghese1 bvarghese1

Labels
enhancement streaming-engine Tickets owned by the ksqlDB Streaming Team user-defined-functions Tickets about UDF, UDAF, UDTF
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jnh5y @bvarghese1 @suhas-satish