Enable bytes and string data types for max/min udaf #9081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The max and min udaf was generalized to handle date & time data types See - 5134393 - As a result, the code was capable of supporting string and bytes data types - This commit simply enables them in the max and min udaf's
jnh5y
reviewed
Apr 28, 2022
| @@ -52,6 +52,8 @@ public KsqlAggregateFunction createAggregateFunction( | |||
| case DATE: | |||
| case TIME: | |||
| case TIMESTAMP: | |||
| case STRING: | |||
jzaralim
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable bytes n string data types for max/min udaf
Testing done
Added unit and integration tests
Reviewer checklist