feat: Support MIN/MAX udafs for Time/TS/Date types #8924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnh5y
reviewed
Mar 24, 2022
ksqldb-functional-tests/src/test/resources/query-validation-tests/max-group-by.json
Show resolved
Hide resolved
jnh5y
reviewed
Mar 24, 2022
ksqldb-engine/src/main/java/io/confluent/ksql/function/udaf/BaseDateKudaf.java
Outdated
Show resolved
Hide resolved
|
Also, you'll want to add the new types to |
Actually, I misspoke, you'll want to update |
jnh5y
reviewed
Mar 24, 2022
ksqldb-engine/src/main/java/io/confluent/ksql/function/udaf/max/TimeMaxKudaf.java
Outdated
Show resolved
Hide resolved
pgaref
force-pushed
the
min-max-date-ts
branch
2 times, most recently
from
d0ce164
to
32c1173
Compare
jnh5y
approved these changes
Mar 25, 2022
spena
reviewed
Mar 25, 2022
ksqldb-engine/src/main/java/io/confluent/ksql/function/udaf/BaseComparableKudaf.java
Show resolved
Hide resolved
ksqldb-engine/src/main/java/io/confluent/ksql/function/udaf/max/MaxComparableKudaf.java
Outdated
Show resolved
Hide resolved
spena
reviewed
Mar 29, 2022
ksqldb-engine/src/main/java/io/confluent/ksql/function/udaf/BaseComparableKudaf.java
Outdated
Show resolved
Hide resolved
pgaref
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Natively support MIN/MAX aggregations for DATE, TIME, and TIMESTAMP types.
All existing types implement Comparable interface so a base BaseComparableKudaf replaced BaseNumberKudaf and appropriate 2 Min/Max Kudafs were implemented (getting rid of 12+ type specific implementations).
Addresses #8757
Testing done
Added unit Tests for every type - Min/Max combination
Extended max-group-by min-group-by functional tests
Reviewer checklist