-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes timeout for owner lookup in StaticQueryExecutor and rebalancin… #3856
Makes timeout for owner lookup in StaticQueryExecutor and rebalancin… #3856
Conversation
It looks like @AlanConfluent hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there's some leftover constants that should be removed, maybe rename a config, and one typo (I think). Also, this is my first time looking into the KsStateStoreTest.java
, @big-andy-coates what is this line doing if the timeout variable isn't being used in the test?
@Rule
public final Timeout timeout = Timeout.seconds(10);
ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/execution/StaticQueryExecutor.java
Show resolved
Hide resolved
...reams/src/main/java/io/confluent/ksql/execution/streams/materialization/ks/KsStateStore.java
Show resolved
Hide resolved
clabot:check |
ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/execution/StaticQueryExecutor.java
Outdated
Show resolved
Hide resolved
ksql-common/src/main/java/io/confluent/ksql/util/KsqlConfig.java
Outdated
Show resolved
Hide resolved
3313875
to
4f448b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 comment on naming. Let me know what you think.
ksql-common/src/main/java/io/confluent/ksql/util/KsqlConfig.java
Outdated
Show resolved
Hide resolved
ksql-common/src/main/java/io/confluent/ksql/util/KsqlConfig.java
Outdated
Show resolved
Hide resolved
0ec8b8f
to
c9d3a5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 1 more thing, based on the issue you filed. You can make the call.
LGTM otherwise.
ksql-common/src/main/java/io/confluent/ksql/util/KsqlConfig.java
Outdated
Show resolved
Hide resolved
…ancing in KsStateStore configurable
c9d3a5e
to
6af3b99
Compare
That will cause the test to fail after 10 seconds if it hasn't completed. |
…g in KsStateStore configurable
Description
Fixes #3573
Both timeouts in StaticQueryExecutor and KsStateStore have been factored out to a configuration value that can be updated.
Testing done
Ran all unit tests by
mvn clean install checkstyle:check integration-test
Reviewer checklist