chore: update KSQL_PULL_QUERIES_ENABLE_CONFIG name (MINOR) #4042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -204,7 +204,7 @@ | |||
| + " which are secured with ACLs. Please enable only after careful consideration." | |||
| + " If \"false\", KSQL pull queries will fail against a secure Kafka cluster"; | |||
|
|
|||
| public static final String KSQL_PULL_QUERIES_ENABLE_CONFIG = "ksql.pull.queries.enable"; | |||
| public static final String KSQL_PULL_QUERIES_ENABLE_CONFIG = "ksql.query.pull.enable"; | |||
There was a problem hiding this comment.
Does it matter that the variable names are non consistent with the config name? ("KSQL_PULL_QUERIES_ENABLE_CONFIG").
I assume not, since we don't publish these branches, do we?
There was a problem hiding this comment.
I think it's ok. The config names are supposed to be hierarchical, but a variable named that way is less readable.
|
LGTM from me. |
2 tasks
|
Closing in favor of #4059 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#3778 introduced a config named
ksql.pull.queries.enablefor enabling/disabling pull queries. The config was renamed toksql.query.pull.enablein #3856 after the 5.4.x branch was cut, and has therefore introduced a breaking change between 5.4 and master. This PR updates the config name in 5.4 to match the new name on master.Testing done
Verified there are no docs or examples using the old config name that need to be updated. No additional code changes are needed since only the variable
KSQL_PULL_QUERIES_ENABLE_CONFIGis used throughout the code.Reviewer checklist