fix: do not allow grouping sets #4942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: confluentinc#4939 Change to SQL syntax to not allow GROUP BY and PARTITION BY on boolean expressions. Only value expressions will be allowed.
fixes: confluentinc#4941 Change the ksqlDB syntax to now allow grouping sets, which aren't supported yet.
Conflicting files ksqldb-parser/src/main/antlr4/io/confluent/ksql/parser/SqlBase.g4 ksqldb-parser/src/main/java/io/confluent/ksql/parser/AstBuilder.java
agavra
suggested changes
Mar 31, 2020
| @@ -129,7 +129,7 @@ void setWhereExpression(final Expression whereExpression) { | |||
| return ImmutableList.copyOf(groupByExpressions); | |||
| } | |||
|
|
|||
| void addGroupByExpressions(final Set<Expression> expressions) { | |||
| void addGroupByExpressions(final Collection<Expression> expressions) { | |||
There was a problem hiding this comment.
shouldn't grouping expressions be a unique set though ? what does it mean to group by a,a,b,a ? it's possible i'm entirely misunderstanding what this piece of code does though, rusty on this stuff ;) Comment applies regardless of whether the groupingExpression is retained (per Almog's suggestion) or not - i think....
There was a problem hiding this comment.
That's a good point Nick. The old code didn't actually enforce this as addGroupByExpressions was called multiple times.
I've corrected the code and added tests to cover this. Now:
CREATE TABLE OUTPUT AS SELECT COUNT(*) FROM TEST GROUP BY DATA, DATA;Results in an error:
Duplicate GROUP BY expression: TEST.DATA
The old code was also not maintaining the order of the GROUP BY expressions. This has also been fixed in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: this PR is stacked on top of #4940. Only review the second commit onwards.
fixes: #4941
Change the ksqlDB syntax to not allow grouping sets, which aren't supported yet.
This is backwards compatible for already running queries, as they are built from the query plan, not the syntax.
Testing done
usual.
Reviewer checklist