Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose AVRO and JSON_SR as key formats #6694

Merged
merged 6 commits into from
Dec 2, 2020

Conversation

vcrfxia
Copy link
Contributor

@vcrfxia vcrfxia commented Dec 1, 2020

Description

This PR un-hides AVRO and JSON_SR from behind the feature flag, and cleans up a bunch of feature flag appearances in tests accordingly. Review the first commit to avoid scrolling through the new QTT historic plans.

Testing done

QTT

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@vcrfxia vcrfxia requested a review from a team as a code owner December 1, 2020 05:26
@vcrfxia vcrfxia mentioned this pull request Dec 1, 2020
2 tasks
@vcrfxia
Copy link
Contributor Author

vcrfxia commented Dec 2, 2020

Merging based on approval from #6695, which is stacked on this one.

@vcrfxia vcrfxia merged commit 07dc0c7 into confluentinc:master Dec 2, 2020
@vcrfxia vcrfxia deleted the avro-json-sr-keys branch December 2, 2020 01:16
@vcrfxia vcrfxia mentioned this pull request Dec 2, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant