chore: split key format feature flag #6695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agavra
approved these changes
Dec 1, 2020
| @@ -138,7 +138,17 @@ | |||
| public static final String KSQL_KEY_FORMAT_ENABLED = "ksql.key.format.enabled"; | |||
There was a problem hiding this comment.
i've merged the other PR, so if you want to we can rename this (or just leave it as is, i'm OK with that too)
There was a problem hiding this comment.
I'll leave it for now since the old name is already embedded in some historic plans (with value false), no need to introduce yet another config to clutter the history. Plus this flag is going away soon ;D
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is stacked on #6694. Only the last commit needs to be reviewed.
This PR separates the current key format feature flag (
ksql.key.format.enabled) into three:ksql.key.format.enabled: controls the addition of new key formats. I've kept the old name in order to avoid clashes with feat: support PROTOBUF keys #6692ksql.complex.key.format.enabled: controls support for array and struct keysksql.multicol.key.format.enabled: controls support for multi-column keysTesting done
QTT
Reviewer checklist