chore: fix pull queries in https://docs/concepts/queries.md #7597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimGalasyn
approved these changes
May 26, 2021
AlanConfluent
approved these changes
May 26, 2021
|
|
||
| - In addition, windowed tables support bounds on `WINDOWSTART` and `WINDOWEND` using operators | ||
| `<=`, `<`, `=`, `>`, `>=`. | ||
| - JOIN, PARTITION BY, GROUP BY and WINDOW clauses aren't supported. |
There was a problem hiding this comment.
Do we mention this in the other doc?
There was a problem hiding this comment.
We implicitly mention this by saying
Synopsis:
SELECT select_expr [, ...]
FROM table
[ WHERE where_condition ]
[ AND window_bounds ];
There was a problem hiding this comment.
I am explicitly adding some of this info in the other doc as well
cprasad1
added a commit
to cprasad1/ksql
that referenced
this pull request
May 26, 2021
…tinc#7597) * chore: fix pull queries in docs/concepts/queries.md * nit in language Co-authored-by: Chittaranjan Prasad <>
2 tasks
cprasad1
added a commit
to cprasad1/ksql
that referenced
this pull request
May 26, 2021
…tinc#7597) * chore: fix pull queries in docs/concepts/queries.md * nit in language Co-authored-by: Chittaranjan Prasad <>
2 tasks
cprasad1
added a commit
that referenced
this pull request
May 26, 2021
cprasad1
added a commit
that referenced
this pull request
May 26, 2021
cprasad1
added a commit
that referenced
this pull request
May 27, 2021
* chore: fix pull queries in https://docs/concepts/queries.md (#7597) * chore: fix pull queries in docs/concepts/queries.md * nit in language Co-authored-by: Chittaranjan Prasad <> * docs: rewrite pull query docs page (#7532) * chore: rewrite pull query docs page * revise some more * incorporate Alan's comment * explicitly call out features and limitations * Update docs/developer-guide/ksqldb-reference/select-pull-query.md Co-authored-by: Almog Gavra <[email protected]> * Update docs/developer-guide/ksqldb-reference/select-pull-query.md Co-authored-by: Almog Gavra <[email protected]> * Update docs/developer-guide/ksqldb-reference/select-pull-query.md Co-authored-by: Almog Gavra <[email protected]> * Update docs/developer-guide/ksqldb-reference/select-pull-query.md Co-authored-by: Almog Gavra <[email protected]> * Update docs/developer-guide/ksqldb-reference/select-pull-query.md Co-authored-by: Almog Gavra <[email protected]> * nits Co-authored-by: Chittaranjan Prasad <> Co-authored-by: Almog Gavra <[email protected]> Co-authored-by: Almog Gavra <[email protected]>
cprasad1
added a commit
that referenced
this pull request
May 27, 2021
* chore: fix pull queries in https://docs/concepts/queries.md (#7597) * chore: fix pull queries in docs/concepts/queries.md * nit in language Co-authored-by: Chittaranjan Prasad <> * docs: rewrite pull query docs page (#7532) * chore: rewrite pull query docs page * revise some more * incorporate Alan's comment * explicitly call out features and limitations * Update docs/developer-guide/ksqldb-reference/select-pull-query.md Co-authored-by: Almog Gavra <[email protected]> * Update docs/developer-guide/ksqldb-reference/select-pull-query.md Co-authored-by: Almog Gavra <[email protected]> * Update docs/developer-guide/ksqldb-reference/select-pull-query.md Co-authored-by: Almog Gavra <[email protected]> * Update docs/developer-guide/ksqldb-reference/select-pull-query.md Co-authored-by: Almog Gavra <[email protected]> * Update docs/developer-guide/ksqldb-reference/select-pull-query.md Co-authored-by: Almog Gavra <[email protected]> * nits Co-authored-by: Chittaranjan Prasad <> Co-authored-by: Almog Gavra <[email protected]> Co-authored-by: Almog Gavra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix pull queries' description in https://docs/concepts/queries.md by deleting an entire section on
Pull query features and limitationsand just adding a link to https://docs.ksqldb.io/en/latest/developer-guide/ksqldb-reference/select-pull-query/ insteadTesting done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist