Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rewrite pull query docs page #7603

Merged
merged 2 commits into from
May 27, 2021

Conversation

cprasad1
Copy link
Member

Description

cherry-picking #7532 for manual sync

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

cprasad1 and others added 2 commits May 26, 2021 15:55
…tinc#7597)

* chore: fix pull queries in docs/concepts/queries.md

* nit in language

Co-authored-by: Chittaranjan Prasad <>
* chore: rewrite pull query docs page

* revise some more

* incorporate Alan's comment

* explicitly call out features and limitations

* Update docs/developer-guide/ksqldb-reference/select-pull-query.md

Co-authored-by: Almog Gavra <[email protected]>

* Update docs/developer-guide/ksqldb-reference/select-pull-query.md

Co-authored-by: Almog Gavra <[email protected]>

* Update docs/developer-guide/ksqldb-reference/select-pull-query.md

Co-authored-by: Almog Gavra <[email protected]>

* Update docs/developer-guide/ksqldb-reference/select-pull-query.md

Co-authored-by: Almog Gavra <[email protected]>

* Update docs/developer-guide/ksqldb-reference/select-pull-query.md

Co-authored-by: Almog Gavra <[email protected]>

* nits

Co-authored-by: Chittaranjan Prasad <>
Co-authored-by: Almog Gavra <[email protected]>
@cprasad1 cprasad1 requested review from JimGalasyn and a team as code owners May 27, 2021 20:36
@cprasad1 cprasad1 merged commit cef2246 into confluentinc:0.18.0-ksqldb May 27, 2021
@cprasad1 cprasad1 deleted the 0.18.0-ksqldb branch May 27, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants