feat: fail scalable push query if error is detected in subscribed persistent query #7996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksqldb-engine/src/main/java/io/confluent/ksql/util/PersistentQueryMetadataImpl.java
Outdated
Show resolved
Hide resolved
ksqldb-engine/src/main/java/io/confluent/ksql/util/PersistentQueryMetadataImpl.java
Outdated
Show resolved
Hide resolved
| queryErrors.add(queryError); | ||
| LOG.error( | ||
| "Unhandled exception caught in streams thread {}. ({})", | ||
| Thread.currentThread().getName(), | ||
| errorType, | ||
| e | ||
| ); | ||
| listener.onError(this, queryError); |
There was a problem hiding this comment.
Curious, why was it required to move this call?
There was a problem hiding this comment.
I was failing some tests in SecureIntegrationTest that called assertQueryFailsWithUserError. It seemed that the queryError was not being added and so the tests failed, but when i moved the listener to the end they passed
There was a problem hiding this comment.
We looked into this offline and this line can be reverted.
...b-engine/src/test/java/io/confluent/ksql/physical/scalablepush/ScalablePushRegistryTest.java
Outdated
Show resolved
Hide resolved
ksqldb-engine/src/test/java/io/confluent/ksql/physical/scalablepush/PushPhysicalPlanTest.java
Show resolved
Hide resolved
AlanConfluent
approved these changes
Aug 17, 2021
ksqldb-engine/src/main/java/io/confluent/ksql/util/PersistentQueryMetadataImpl.java
Outdated
Show resolved
Hide resolved
ksqldb-engine/src/main/java/io/confluent/ksql/query/TransientQueryQueue.java
Outdated
Show resolved
Hide resolved
| queryErrors.add(queryError); | ||
| LOG.error( | ||
| "Unhandled exception caught in streams thread {}. ({})", | ||
| Thread.currentThread().getName(), | ||
| errorType, | ||
| e | ||
| ); | ||
| listener.onError(this, queryError); |
There was a problem hiding this comment.
We looked into this offline and this line can be reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Listen for errors in the persistent query that a scalable push query is subscribed to and if one occurs, fail the scalable push query.
Testing done
Unit tests added, as well as manual testing to ensure that we see
Persistent query has erroron the CLI.Reviewer checklist