Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fail scalable push query if error is detected in subscribed persistent query #7996
feat: fail scalable push query if error is detected in subscribed persistent query #7996
Changes from 19 commits
b4f8aa5
f3e2b75
bd8ab5b
65afc21
fc82fcb
f342ac9
0c9b523
ce87956
33b2e64
29fcf5b
0cce482
50955dc
7133868
51dd475
3b32d49
be83edc
eafd312
7b5b774
4dda527
d460854
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, why was it required to move this call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was failing some tests in
SecureIntegrationTest
that calledassertQueryFailsWithUserError
. It seemed that thequeryError
was not being added and so the tests failed, but when i moved the listener to the end they passedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We looked into this offline and this line can be reverted.