test: Fix and improve the test QuickDegradeAndRestoreCommandTopicIntegrationTest #8275
Conversation
…est by checking for topic deletion status via assertThatEventually() before checking for degraded state. If the command topic gets recreated somehow and is the reason behind the flakiness, this change helps to isolate that.
…Test which lead to automatic recreation of deleted command topic by setting Kafka config: auto.create.topics.enable to false. Also, added another check to ensure command topic is deleted before stopping ksqldb.
mkandaswamy
changed the title
There was a problem hiding this comment.
Besides changing the auto topic creation property to be false for just this test, LGTM otherwise (I think it should also help you get a green build on jenkins)! Thank you for the quick fix @mkandaswamy!
| config.put(KafkaConfig.AutoCreateTopicsEnableProp(), true); | ||
| // Create topics explicitly when needed to avoid a race which | ||
| // automatically recreates deleted command topic: | ||
| config.put(KafkaConfig.AutoCreateTopicsEnableProp(), false); |
There was a problem hiding this comment.
I'm worried that there may be many tests that rely on automatically creating topics. Is there way to set this config but at the test level instead?
There was a problem hiding this comment.
If you look at ApiIntegrationTest, when it creates the TEST_HARNESS it configure the properties it needs for the kafka cluster as follows:
private static final IntegrationTestHarness TEST_HARNESS = IntegrationTestHarness.builder()
.withKafkaCluster(
EmbeddedSingleNodeKafkaCluster.newBuilder()
.withoutPlainListeners()
.withSaslSslListeners()
).build();Can we do something similar here and create a function to remove the auto topic creation for just this test?
There was a problem hiding this comment.
Yes, seem like few tests do depend on that setting to be true. I've addressed this in my latest commit. For now, only QuickDegradeAndRestoreCommandTopicIntegrationTest will set automatically creating topics to be false.
| REST_APP.stop(); | ||
| REST_APP.start(); | ||
|
|
||
| // Then | ||
| assertThatEventually("Topic Deleted", this::isCommandTopicDeleted, is(true)); |
…e as few tests depend on that setting. Also, added new method withoutAutoCreateTopics() to create Kafka cluster with auto create topics feature turned off. This method is used by QuickDegradeAndRestoreCommandTopicIntegrationTest to fix a race which lead to automatic recreation of deleted command topic.
Description
KSQL-7430
Improve the test QuickDegradeAndRestoreCommandTopicIntegrationTest by checking for topic deletion status via assertThatEventually() before checking for degraded state and also after right after deleting the command topic.
Also, fixed a race which lead to automatic recreation of deleted command topic by setting Kafka config: auto.create.topics.enable to be false in QuickDegradeAndRestoreCommandTopicIntegrationTest.
Testing done
Tested the change locally by running integration tests multiple times .
Reviewer checklist