Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix_application_id_to_work_with_acls #8277

Merged
merged 2 commits into from
Oct 22, 2021
Merged

fix: fix_application_id_to_work_with_acls #8277

merged 2 commits into from
Oct 22, 2021

Conversation

wcarlson5
Copy link
Contributor

Description

What behavior do you want to change, why, how does your patch achieve the changes?

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@wcarlson5 wcarlson5 requested a review from a team as a code owner October 21, 2021 19:38
@wcarlson5
Copy link
Contributor Author

@mjsax do you think I can sneak this in to the next RC for 0.22?
@nae701 what about 0.23?

@wcarlson5
Copy link
Contributor Author

@ableegoldman This will need to get included in your PR moving the selection of runtimes

@ableegoldman
Copy link
Contributor

It would be great if we could get this in to 0.22 @mjsax (though I wouldn't cut a new RC for it if we don't otherwise need one)

Definitely should be in 0.23 @nateab

Copy link
Contributor

@ableegoldman ableegoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nateab
Copy link
Member

nateab commented Oct 21, 2021

We can get this in 0.23, will probably cut later today then once this and #8275 is merged

@wcarlson5 wcarlson5 merged commit 64f58e8 into confluentinc:master Oct 22, 2021
@wcarlson5 wcarlson5 deleted the fix_application_id_to_work_with_acls branch November 8, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants