fix: remove usages of internal Streams API/variable that was removed upstream #8660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…StreamsMetadataImpl.NOT_AVAILABLE variable which was just deleted upstream in AK
patrickstuedi
approved these changes
Jan 26, 2022
2 tasks
|
Merging ASAP since this is blocking the 0.24 release and the build in general, I did test locally to make sure the patch fixes the build but if there are test failures somehow that come up later they should be addressed in a followup PR |
|
@ableegoldman @guozhangwang I peeked at this and tossed up a PR to fix the |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently we used the StreamsMetadataImpl.NOT_AVAILABLE variable throughout the ksql repo, but we very much should not have been since this is actually not in the public API of Streams. The risk of using internal APIs is that they have no public contract or compatability guarantees of any kind, and can for example be removed at any time without deprecation/warning.
Unfortunately this is exactly what just happened to
StreamsMetadataImpl.NOT_AVAILABLE, but at least we can easily address this since it was pretty much just a convenience to begin with used for comparisons, and we no longer return any metadata for unavailable clients rather than build up this metadata and then just filter it out on the user side (ie ksql)