Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixes the AllHostsLocatorTest #8664

Merged
merged 1 commit into from
Jan 27, 2022
Merged

fix: Fixes the AllHostsLocatorTest #8664

merged 1 commit into from
Jan 27, 2022

Conversation

jnh5y
Copy link
Member

@jnh5y jnh5y commented Jan 26, 2022

Description

Fixes the AllHostsLocatorTest by adding back the metadata variable.

@jnh5y jnh5y requested a review from a team as a code owner January 26, 2022 20:28
@jnh5y jnh5y mentioned this pull request Jan 26, 2022
Merged
@jnh5y
Copy link
Member Author

jnh5y commented Jan 26, 2022

Hmm... CI failed on

[2022-01-26T22:26:35.832Z] [ERROR]   PullQueryRoutingFunctionalTest.shouldQueryStandbyWhenActiveDeadStandbyAliveQueryIssuedToRouter:398 
[2022-01-26T22:26:35.832Z] Expected: is <3089>
[2022-01-26T22:26:35.832Z]      but: was <3942>
[2022-01-26T22:26:35.833Z] [ERROR] Errors: 
[2022-01-26T22:26:35.833Z] [ERROR] io.confluent.ksql.rest.integration.PullQueryRoutingFunctionalTest.shouldFilterLaggyServers
[2022-01-26T22:26:35.833Z] [ERROR]   Run 1: PullQueryRoutingFunctionalTest.shouldFilterLaggyServers:466 » TestTimedOut tes...
[2022-01-26T22:26:35.833Z] [ERROR]   Run 2: PullQueryRoutingFunctionalTest.shouldFilterLaggyServers »  Appears to be stuck...
[2022-01-26T22:26:35.833Z] [INFO] 
[2022-01-26T22:26:35.833Z] [ERROR]   PullQueryRoutingFunctionalTest.shouldQueryActiveWhenActiveAliveQueryIssuedToStandby » Runtime
[2022-01-26T22:26:35.833Z] [ERROR]   PullQueryRoutingFunctionalTest.shouldQueryActiveWhenActiveAliveStandbyDeadQueryIssuedToRouter » Runtime
[2022-01-26T22:26:35.833Z] [ERROR]   PullQueryRoutingFunctionalTest.shouldQueryStandbyWhenActiveDeadStandbyAliveQueryIssuedToRouter_multipleKeys » Runtime```

I wonder if those tests are non-deterministic / flaky.

@Gerrrr Gerrrr mentioned this pull request Jan 27, 2022
Merged
2 tasks
@wcarlson5 wcarlson5 mentioned this pull request Jan 27, 2022
Merged
2 tasks
@jnh5y jnh5y mentioned this pull request Jan 27, 2022
Closed
2 tasks
@jnh5y jnh5y merged commit 802f130 into master Jan 27, 2022
@jnh5y jnh5y deleted the fix-all-hosts-locator-test branch January 27, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ableegoldman ableegoldman Awaiting requested review from ableegoldman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jnh5y