Follow-up fixes for #996 #1003
Open
Follow-up fixes for #996 #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making an empty list a default argument is dangerous because lists are mutable. Luckily for us the argument isn't being updated in the function. Still, a tuple is the suggested approach here. While at it, add a doc string entry for the argument in question. Signed-off-by: Erik Skultety <[email protected]>
We should only really need to set GOSUMDB explicitly with the module fetch so that we can verify e.g. a toolchain that was downloaded as a result of using GOTOOLCHAIN=auto in resolve_gomod. Every other occurrence where we explicitly disable GOSUMDB is redundant. As for hermetic (i.e. network isolated) builds, as long GOMODCACHE is provided, the sum database should not be needed. As far as additional toolchains are concerned with regards to checking the sum database during offline project builds, setting the GOPROXY variable to point to the correct location on disk within GOMODCACHE should be enough to pass any kind of verification. Signed-off-by: Erik Skultety <[email protected]>
eskultety
requested review from
taylormadore and
brunoapimentel
and removed request for
taylormadore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GOSUMDB=offassignments and only set it to its default value forresolve_gomodMaintainers will complete the following section