Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up fixes for #996 #1003

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Follow-up fixes for #996 #1003

wants to merge 2 commits into from

Commits on May 29, 2024

  1. tests: utils: assert_directories_equal: Convert ignore_files to a tuple 

    Making an empty list a default argument is dangerous because lists are
mutable. Luckily for us the argument isn't being updated in the
function. Still, a tuple is the suggested approach here.

While at it, add a doc string entry for the argument in question.

Signed-off-by: Erik Skultety <[email protected]>
    @eskultety
    eskultety committed May 29, 2024
    Configuration menu
    Copy the full SHA
    9141f5b View commit details
    Browse the repository at this point in the history

  2. workers: Drop explicit GOSUMDB=off setting occurrences 

    We should only really need to set GOSUMDB explicitly with the module
fetch so that we can verify e.g. a toolchain that was downloaded as a
result of using GOTOOLCHAIN=auto in resolve_gomod.
Every other occurrence where we explicitly disable GOSUMDB is
redundant. As for hermetic (i.e. network isolated) builds, as long
GOMODCACHE is provided, the sum database should not be needed. As far
as additional toolchains are concerned with regards to checking the sum
database during offline project builds, setting the GOPROXY variable to
point to the correct location on disk within GOMODCACHE should be
enough to pass any kind of verification.

Signed-off-by: Erik Skultety <[email protected]>
    @eskultety
    eskultety committed May 29, 2024
    Configuration menu
    Copy the full SHA
    a3540cf View commit details
    Browse the repository at this point in the history