Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Windows CI failure with containerd 1.5.8 #534

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda marked this pull request as draft November 18, 2021 11:29
@AkihiroSuda AkihiroSuda added area/ci e.g., CI failure platform/Windows/Non-WSL2 Microsoft Windows (non-WSL2) labels Nov 18, 2021
@AkihiroSuda AkihiroSuda force-pushed the debug-windows-containerd-1.5.8 branch 7 times, most recently from 3ee31d7 to 60a65cf Compare November 18, 2021 12:12
@jsturtevant
Copy link
Contributor

is there a way to retrigger a single test? I think the changes here will work based on #533 (comment)

@AkihiroSuda
Copy link
Member Author

is there a way to retrigger a single test? I think the changes here will work based on #533 (comment)

A reviewer/committer can retrigger a single Cirrus test (and the entire GHA tests).

Would you be interested in being a reviewer (and eventually a comitter) of nerdctl ?
https://github.com/containerd/project/blob/main/GOVERNANCE.md

@jsturtevant
Copy link
Contributor

As expected the exec's are working when used directly. It seems the test framework might be holding onto a file reference somewhere:

CI run with exec directly works:

hello
+ echo hello2
hello2
6e6af0200fe8d0d97bea42b372263f5926f9a523c80679e9e2721e1c86f62ad8
hello3
nerdctl-test-exec
bfca23b3985de4108463b70a5c8db8b7d61192c025d23c898ba1cf87a1a74d60
+ echo hello4
hello4

@jsturtevant
Copy link
Contributor

A reviewer/committer can retrigger a single Cirrus test (and the entire GHA tests).

Would you be interested in being a reviewer (and eventually a comitter) of nerdctl ? https://github.com/containerd/project/blob/main/GOVERNANCE.md

Not sure I've done enough yet 😊 and I may only be helpful from Windows side given my current knowledge but would be interested.

- nerdctl exec nerdctl-test-exec echo hello3
- nerdctl rm -f nerdctl-test-exec

- nerdctl run -d --name nerdctl-test-exec gcr.io/k8s-staging-e2e-test-images/busybox:1.29-2 sh -euxc "sleep 1h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- nerdctl run -d --name nerdctl-test-exec gcr.io/k8s-staging-e2e-test-images/busybox:1.29-2 sh -euxc "sleep 1h"
- nerdctl run -d --name nerdctl-test-exec gcr.io/k8s-staging-e2e-test-images/busybox:1.29-2 sh -eux "sleep 1h"

still working on why but this should let it pass

@AkihiroSuda
Copy link
Member Author

A reviewer/committer can retrigger a single Cirrus test (and the entire GHA tests).
Would you be interested in being a reviewer (and eventually a comitter) of nerdctl ? https://github.com/containerd/project/blob/main/GOVERNANCE.md

Not sure I've done enough yet 😊 and I may only be helpful from Windows side given my current knowledge but would be interested.

Thanks, opened #562 to add you as a Reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci e.g., CI failure platform/Windows/Non-WSL2 Microsoft Windows (non-WSL2)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants