Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINTAINERS: add James Sturtevant as a REVIEWER #562

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Nov 24, 2021

@jsturtevant has made significant contributions for supporting Windows (https://github.com/containerd/nerdctl/issues?q=author%3Ajsturtevant), so I'd like to invite @jsturtevant to be a Reviewer.

Needs explicit LGTM from:

I'd also like to get a few LGTMs from the Core Committers too.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsturtevant
Copy link
Contributor

LGTM

Thank you!

Copy link
Member

@kevpar kevpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@AkihiroSuda AkihiroSuda merged commit e053d51 into containerd:master Nov 30, 2021
@AkihiroSuda AkihiroSuda added this to the v0.15.0 milestone Nov 30, 2021
@AkihiroSuda
Copy link
Member Author

@jsturtevant Did you receive an invitation to join https://github.com/containerd org ?

@jsturtevant
Copy link
Contributor

Received it yesterday. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants