Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If streams cannot be locked, it will cause a panic #233

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

jokemanfire
Copy link
Contributor

No description provided.

@Tim-Zhang
Copy link
Member

Hi @jokemanfire, thank you for your pull request. The CI failed because the commit body is missing and I have left a review comment. Thanks

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 24.73%. Comparing base (a9198f2) to head (bf021aa).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
src/asynchronous/client.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   24.97%   24.73%   -0.24%     
==========================================
  Files          16       16              
  Lines        2651     2676      +25     
==========================================
  Hits          662      662              
- Misses       1989     2014      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/asynchronous/client.rs Outdated Show resolved Hide resolved
src/asynchronous/client.rs Outdated Show resolved Hide resolved
If streams cannot be locked, it will cause a panic

Signed-off-by: jokemanfire <[email protected]>
Copy link
Member

@Tim-Zhang Tim-Zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @jokemanfire.

@Tim-Zhang Tim-Zhang merged commit 8caf5ec into containerd:master Sep 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants