buildah, bud: support --jobs=N for parallel execution #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
force-pushed
the
parallel-stages
branch
from
38051e7
to
7d07a3c
Compare
rhatdan
reviewed
Jun 22, 2020
giuseppe
force-pushed
the
parallel-stages
branch
2 times, most recently
from
dd814ec
to
4502d99
Compare
|
LGTM |
giuseppe
force-pushed
the
parallel-stages
branch
5 times, most recently
from
7943dea
to
f8f6565
Compare
|
@rhatdan tests are passing now |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 29, 2020
2418: buildah, bud: support --jobs=N for parallel execution r=rhatdan a=giuseppe <!-- Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. Uncomment only one `/kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: --> /kind feature #### What this PR does / why we need it: it enables running multi stages Containerfiles in parallel #### How to verify it buildah bud --jobs=$(nproc) ..... #### Which issue(s) this PR fixes: None #### Special notes for your reviewer: #### Does this PR introduce a user-facing change? ```release-note add support for running multi stages Containerfiles in parallel ``` Co-authored-by: Giuseppe Scrivano <[email protected]>
|
Build failed:
|
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jun 29, 2020
2418: buildah, bud: support --jobs=N for parallel execution r=rhatdan a=giuseppe <!-- Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. Uncomment only one `/kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: --> /kind feature #### What this PR does / why we need it: it enables running multi stages Containerfiles in parallel #### How to verify it buildah bud --jobs=$(nproc) ..... #### Which issue(s) this PR fixes: None #### Special notes for your reviewer: #### Does this PR introduce a user-facing change? ```release-note add support for running multi stages Containerfiles in parallel ``` Co-authored-by: Giuseppe Scrivano <[email protected]>
|
Build failed:
|
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jun 30, 2020
2418: buildah, bud: support --jobs=N for parallel execution r=rhatdan a=giuseppe <!-- Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. Uncomment only one `/kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: --> /kind feature #### What this PR does / why we need it: it enables running multi stages Containerfiles in parallel #### How to verify it buildah bud --jobs=$(nproc) ..... #### Which issue(s) this PR fixes: None #### Special notes for your reviewer: #### Does this PR introduce a user-facing change? ```release-note add support for running multi stages Containerfiles in parallel ``` Co-authored-by: Giuseppe Scrivano <[email protected]>
|
Build failed:
|
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jun 30, 2020
2418: buildah, bud: support --jobs=N for parallel execution r=rhatdan a=giuseppe <!-- Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. Uncomment only one `/kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: --> /kind feature #### What this PR does / why we need it: it enables running multi stages Containerfiles in parallel #### How to verify it buildah bud --jobs=$(nproc) ..... #### Which issue(s) this PR fixes: None #### Special notes for your reviewer: #### Does this PR introduce a user-facing change? ```release-note add support for running multi stages Containerfiles in parallel ``` Co-authored-by: Giuseppe Scrivano <[email protected]>
|
Giuseppe, this needs a rebase and I think that will also pull in a fix in #2427 that will help get the tests happy. |
Signed-off-by: Giuseppe Scrivano <[email protected]>
it enables running multi stages Containerfiles in parallel. Signed-off-by: Giuseppe Scrivano <[email protected]>
|
rebased and tests are green |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 1, 2020
2418: buildah, bud: support --jobs=N for parallel execution r=rhatdan a=giuseppe <!-- Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. Uncomment only one `/kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: --> /kind feature #### What this PR does / why we need it: it enables running multi stages Containerfiles in parallel #### How to verify it buildah bud --jobs=$(nproc) ..... #### Which issue(s) this PR fixes: None #### Special notes for your reviewer: #### Does this PR introduce a user-facing change? ```release-note add support for running multi stages Containerfiles in parallel ``` 2422: Add bud regression tests r=rhatdan a=TomSweeneyRedHat We recently made a couple of commits to the imagebuilder project to address #2345 and #2192. Tests were created in that project, but I thought it best to add some regression tests here in Buildah too. FYI: @petr-motejlek and @tachoknight Signed-off-by: TomSweeneyRedHat <[email protected]> <!-- Thanks for sending a pull request! Please make sure you've read and understood our contributing guidelines (https://github.com/containers/buildah/blob/master/CONTRIBUTING.md) as well as ensuring that all your commits are signed with `git commit -s`. --> #### What type of PR is this? <!-- Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. Uncomment only one `/kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: --> > /kind api-change > /kind bug > /kind cleanup > /kind deprecation > /kind design > /kind documentation > /kind failing-test > /kind feature > /kind flake > /kind other #### What this PR does / why we need it: #### How to verify it #### Which issue(s) this PR fixes: <!-- Automatically closes linked issue when PR is merged. Uncomment the following comment block and include the issue number or None on one line. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`, or `None`. --> <!-- Fixes # or None --> #### Special notes for your reviewer: #### Does this PR introduce a user-facing change? <!-- If no, just write `None` in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information on release notes please follow the kubernetes model: https://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note ``` Co-authored-by: Giuseppe Scrivano <[email protected]> Co-authored-by: TomSweeneyRedHat <[email protected]>
|
Build failed (retrying...):
|
bors bot
added a commit
that referenced
this pull request
Jul 1, 2020
2418: buildah, bud: support --jobs=N for parallel execution r=rhatdan a=giuseppe <!-- Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. Uncomment only one `/kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: --> /kind feature #### What this PR does / why we need it: it enables running multi stages Containerfiles in parallel #### How to verify it buildah bud --jobs=$(nproc) ..... #### Which issue(s) this PR fixes: None #### Special notes for your reviewer: #### Does this PR introduce a user-facing change? ```release-note add support for running multi stages Containerfiles in parallel ``` Co-authored-by: Giuseppe Scrivano <[email protected]>
|
Build failed:
|
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jul 1, 2020
2418: buildah, bud: support --jobs=N for parallel execution r=rhatdan a=giuseppe <!-- Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. Uncomment only one `/kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: --> /kind feature #### What this PR does / why we need it: it enables running multi stages Containerfiles in parallel #### How to verify it buildah bud --jobs=$(nproc) ..... #### Which issue(s) this PR fixes: None #### Special notes for your reviewer: #### Does this PR introduce a user-facing change? ```release-note add support for running multi stages Containerfiles in parallel ``` Co-authored-by: Giuseppe Scrivano <[email protected]>
|
Build failed:
|
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jul 1, 2020
2418: buildah, bud: support --jobs=N for parallel execution r=rhatdan a=giuseppe <!-- Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. Uncomment only one `/kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: --> /kind feature #### What this PR does / why we need it: it enables running multi stages Containerfiles in parallel #### How to verify it buildah bud --jobs=$(nproc) ..... #### Which issue(s) this PR fixes: None #### Special notes for your reviewer: #### Does this PR introduce a user-facing change? ```release-note add support for running multi stages Containerfiles in parallel ``` 2430: Bump openshift/imagebuilder to v1.1.6 r=rhatdan a=TomSweeneyRedHat As the title says. Signed-off-by: TomSweeneyRedHat <[email protected]> <!-- Thanks for sending a pull request! Please make sure you've read and understood our contributing guidelines (https://github.com/containers/buildah/blob/master/CONTRIBUTING.md) as well as ensuring that all your commits are signed with `git commit -s`. --> #### What type of PR is this? <!-- Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. Uncomment only one `/kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: --> > /kind api-change > /kind bug > /kind cleanup > /kind deprecation > /kind design > /kind documentation > /kind failing-test > /kind feature > /kind flake > /kind other #### What this PR does / why we need it: #### How to verify it #### Which issue(s) this PR fixes: <!-- Automatically closes linked issue when PR is merged. Uncomment the following comment block and include the issue number or None on one line. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`, or `None`. --> <!-- Fixes # or None --> #### Special notes for your reviewer: #### Does this PR introduce a user-facing change? <!-- If no, just write `None` in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information on release notes please follow the kubernetes model: https://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note ``` Co-authored-by: Giuseppe Scrivano <[email protected]> Co-authored-by: TomSweeneyRedHat <[email protected]>
|
Build failed (retrying...):
|
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind feature
What this PR does / why we need it:
it enables running multi stages Containerfiles in parallel
How to verify it
buildah bud --jobs=$(nproc) .....
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?