Cirrus: Fix missing htpasswd command in registry image #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will fixe the build issues in #2422 and a few others. |
cevich
changed the title
cevich
force-pushed
the
fix_missing_bin_buildah
branch
from
04e9de1
to
226a85e
Compare
|
tests still aren't happy @cevich :^( |
|
&^:angry: ^%$!:angry: :angry: !!FFS#@&!!!!!!!!!!:angry: |
cevich
force-pushed
the
fix_missing_bin_buildah
branch
2 times, most recently
from
ca98619
to
15e5edb
Compare
|
ping @cevich still lots of unlove here for you. |
Recently the registry image was updated significantly with breaking changes. Most were caught, this one was not. Instead of relying on the (clearly) unreliable container image, simply install the package providing the htpasswd command locally. Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
fix_missing_bin_buildah
branch
from
15e5edb
to
8a4646d
Compare
|
@TomSweeneyRedHat got it! |
|
TODO Items addressed here: containers/podman#6822 |
|
@ccevich WOOT! |
|
bors r+ |
|
Build succeeded:
|
edsantiago
reviewed
Jun 30, 2020
This was referenced Jun 30, 2020
Closed
FWIW: This is a temporary change, I've got containers/podman#6822 running to get the package added in the proper packer place. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the registry image was updated significantly with breaking
changes. Most were caught, this one was not. Instead of relying on the
(clearly) unreliable container image, simply install the package
providing the htpasswd command locally.
Signed-off-by: Chris Evich [email protected]