copy: add support for ForceCompressionFormat
#2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mtrmac @vrothberg PTAL |
mtrmac
reviewed
Aug 2, 2023
copy/multiple.go
Outdated
| @@ -230,6 +230,16 @@ func (c *copier) copyMultipleImages(ctx context.Context) (copiedManifest []byte, | |||
| logrus.Debugf("Copying instance %s (%d/%d)", instance.sourceDigest, i+1, len(instanceCopyList)) | |||
| c.Printf("Copying image %s (%d/%d)\n", instance.sourceDigest, i+1, len(instanceCopyList)) | |||
| unparsedInstance := image.UnparsedInstance(c.rawSource, &instanceCopyList[i].sourceDigest) | |||
| singleImageOpts := copySingleImageOptions{requireCompressionFormatMatch: false} | |||
There was a problem hiding this comment.
This value is not actually used AFAICS
I would also prefer it to be set in prepare…; that way we can unit-test this. (I’m not saying that a unit test is required.)
flouthoc
force-pushed
the
implement-forcecompressionformat
branch
from
90d4dd5
to
b0768e3
Compare
|
Addressed all comments @vrothberg @mtrmac PTAL |
flouthoc
force-pushed
the
implement-forcecompressionformat
branch
2 times, most recently
from
587ca74
to
76692b3
Compare
vrothberg
approved these changes
Aug 2, 2023
flouthoc
force-pushed
the
implement-forcecompressionformat
branch
2 times, most recently
from
d357f4e
to
a7556dd
Compare
mtrmac
reviewed
Aug 2, 2023
flouthoc
force-pushed
the
implement-forcecompressionformat
branch
from
a7556dd
to
12c3048
Compare
mtrmac
approved these changes
Aug 3, 2023
| @@ -163,6 +167,14 @@ type copier struct { | |||
| signersToClose []*signer.Signer // Signers that should be closed when this copier is destroyed. | |||
| } | |||
|
|
|||
| // Internal function to validate `requireCompressionFormatMatch` for copySingleImageOptions | |||
| func shouldRequireCompressionFormatMatch(options *Options) (bool, error) { | |||
There was a problem hiding this comment.
(Hiding this somewhere at the bottom, not near the top of the file, might help newcomers to the codebase who want to understand what this file is about.)
ForceCompressionFormat allows end users to force selected compression format (set in DestinationCtx.CompressionFormat) which ensures that while copying blobs of other compression algorithms are not reused. Following flag is a frontend wrapper for: containers#2023 Will help in: * containers/buildah#4613 * containers/podman#18660 Signed-off-by: Aditya R <[email protected]>
mtrmac
force-pushed
the
implement-forcecompressionformat
branch
from
12c3048
to
f406c36
Compare
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Aug 8, 2023
Implement containers/image#2068 for libimage/copier. Signed-off-by: Aditya R <[email protected]>
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Aug 8, 2023
Implement containers/image#2068 for libimage/manifest.Push Signed-off-by: Aditya R <[email protected]>
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Aug 8, 2023
Implement containers/image#2068 for libimage/copier. Signed-off-by: Aditya R <[email protected]>
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Aug 8, 2023
Implement containers/image#2068 for libimage/manifest.Push Signed-off-by: Aditya R <[email protected]>
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Aug 8, 2023
Implement containers/image#2068 for libimage/copier. Signed-off-by: Aditya R <[email protected]>
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Aug 8, 2023
Implement containers/image#2068 for libimage/manifest.Push Signed-off-by: Aditya R <[email protected]>
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Aug 9, 2023
Implement containers/image#2068 for libimage/copier. Signed-off-by: Aditya R <[email protected]>
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Aug 9, 2023
Implement containers/image#2068 for libimage/manifest.Push Signed-off-by: Aditya R <[email protected]>
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Aug 9, 2023
Implement containers/image#2068 for libimage/copier. Signed-off-by: Aditya R <[email protected]>
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Aug 9, 2023
Implement containers/image#2068 for libimage/manifest.Push Signed-off-by: Aditya R <[email protected]>
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Aug 11, 2023
Implement containers/image#2068 for libimage/copier. Signed-off-by: Aditya R <[email protected]>
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Aug 11, 2023
Implement containers/image#2068 for libimage/manifest.Push Signed-off-by: Aditya R <[email protected]>
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Aug 11, 2023
Implement containers/image#2068 for libimage/copier. Signed-off-by: Aditya R <[email protected]>
flouthoc
added a commit
to flouthoc/common
that referenced
this pull request
Aug 11, 2023
Implement containers/image#2068 for libimage/manifest.Push Signed-off-by: Aditya R <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ForceCompressionFormat allows end users to force selected compression format (set in DestinationCtx.CompressionFormat) which ensures that while copying blobs of other compression algorithms are not reused.
Following flag is a frontend wrapper for: #2023
Will help in: