-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compression can't be done when specify option --compression-format in push command. #18660
Comments
@vrothberg @mtrmac PTAL |
I’d expect quite a few more debug logs. Can you run this maybe with (As a guess, layer reuse is prioritized over using the requested compression format. That might need to change eventually, for correctly building Zstd and Gzip-only images.) |
A friendly reminder that this issue had no activity for 30 days. |
@giuseppe isn't this what you have been working on? |
I think this is a different issue |
We are missing debug logs. If my guess is correct, @flouthoc ’s work on zstd clones will will ~require fixing that, e.g. containers/image#1987 (comment) . |
A friendly reminder that this issue had no activity for 30 days. |
@flouthoc has implemented But there are no debug logs in this issue, so we are just guessing that that’s what’s going on. |
Yes I will wire it up with CLI in this coming week, we have a similar issue in buildah. |
ForceCompressionFormat allows end users to force selected compression format (set in DestinationCtx.CompressionFormat) which ensures that while copying blobs of other compression algorithms are not reused. Following flag is a frontend wrapper for: containers#2023 Will help in: * containers/buildah#4613 * containers/podman#18660 Signed-off-by: Aditya R <[email protected]>
ForceCompressionFormat allows end users to force selected compression format (set in DestinationCtx.CompressionFormat) which ensures that while copying blobs of other compression algorithms are not reused. Following flag is a frontend wrapper for: containers#2023 Will help in: * containers/buildah#4613 * containers/podman#18660 Signed-off-by: Aditya R <[email protected]>
ForceCompressionFormat allows end users to force selected compression format (set in DestinationCtx.CompressionFormat) which ensures that while copying blobs of other compression algorithms are not reused. Following flag is a frontend wrapper for: containers#2023 Will help in: * containers/buildah#4613 * containers/podman#18660 Signed-off-by: Aditya R <[email protected]>
ForceCompressionFormat allows end users to force selected compression format (set in DestinationCtx.CompressionFormat) which ensures that while copying blobs of other compression algorithms are not reused. Following flag is a frontend wrapper for: containers#2023 Will help in: * containers/buildah#4613 * containers/podman#18660 Signed-off-by: Aditya R <[email protected]>
ForceCompressionFormat allows end users to force selected compression format (set in DestinationCtx.CompressionFormat) which ensures that while copying blobs of other compression algorithms are not reused. Following flag is a frontend wrapper for: containers#2023 Will help in: * containers/buildah#4613 * containers/podman#18660 Signed-off-by: Aditya R <[email protected]>
ForceCompressionFormat allows end users to force selected compression format (set in DestinationCtx.CompressionFormat) which ensures that while copying blobs of other compression algorithms are not reused. Following flag is a frontend wrapper for: containers#2023 Will help in: * containers/buildah#4613 * containers/podman#18660 Signed-off-by: Aditya R <[email protected]>
ForceCompressionFormat allows end users to force selected compression format (set in DestinationCtx.CompressionFormat) which ensures that while copying blobs of other compression algorithms are not reused. Following flag is a frontend wrapper for: containers#2023 Will help in: * containers/buildah#4613 * containers/podman#18660 Signed-off-by: Aditya R <[email protected]>
ForceCompressionFormat allows end users to force selected compression format (set in DestinationCtx.CompressionFormat) which ensures that while copying blobs of other compression algorithms are not reused. Following flag is a frontend wrapper for: containers#2023 Will help in: * containers/buildah#4613 * containers/podman#18660 Signed-off-by: Aditya R <[email protected]>
Adds support for --force-compression which allows end-users to force push blobs with the selected compresison in --compression option, in order to make sure that blobs of other compression on registry are not reused. Is equivalent to: force-compression here: https://docs.docker.com/build/exporters/#compression Closes: containers#18660 Signed-off-by: Aditya R <[email protected]>
PR #19640 should close this. |
Adds support for --force-compression which allows end-users to force push blobs with the selected compresison in --compression option, in order to make sure that blobs of other compression on registry are not reused. Is equivalent to: force-compression here: https://docs.docker.com/build/exporters/#compression Closes: containers#18660 Signed-off-by: Aditya R <[email protected]>
Adds support for --force-compression which allows end-users to force push blobs with the selected compresison in --compression option, in order to make sure that blobs of other compression on registry are not reused. Is equivalent to: force-compression here: https://docs.docker.com/build/exporters/#compression Closes: containers#18660 Signed-off-by: Aditya R <[email protected]>
Adds support for --force-compression which allows end-users to force push blobs with the selected compresison in --compression option, in order to make sure that blobs of other compression on registry are not reused. Is equivalent to: force-compression here: https://docs.docker.com/build/exporters/#compression Closes: containers#18660 Signed-off-by: Aditya R <[email protected]>
Adds support for --force-compression which allows end-users to force push blobs with the selected compresison in --compression option, in order to make sure that blobs of other compression on registry are not reused. Is equivalent to: force-compression here: https://docs.docker.com/build/exporters/#compression Closes: containers#18660 Signed-off-by: Aditya R <[email protected]>
Adds support for --force-compression which allows end-users to force push blobs with the selected compresison in --compression option, in order to make sure that blobs of other compression on registry are not reused. Is equivalent to: force-compression here: https://docs.docker.com/build/exporters/#compression Closes: containers#18660 Signed-off-by: Aditya R <[email protected]>
Adds support for --force-compression which allows end-users to force push blobs with the selected compresison in --compression option, in order to make sure that blobs of other compression on registry are not reused. Is equivalent to: force-compression here: https://docs.docker.com/build/exporters/#compression Closes: containers#18660 Signed-off-by: Aditya R <[email protected]>
Issue Description
compression can't be done when specify option --compression-format in push command.
Steps to reproduce the issue
podman push --compression-format=gzip --compress --log-level debug httpd dir:/tmp1
DEBU[0005] Checking if we can reuse blob
sha256:01597d537f57d33370c31559a880654ee80571bb5e7c22584629576b4d72b834: general substitution = true, compression for MIME type "application/vnd.docker.image.rootfs.diff.tar" = true
DEBU[0005] exporting filesystem layer "7eee2c97dd0632f3796ea2900ce78ea3f753f4452920b90c583b2
Copying blob 6485bed63627 done
Copying blob 34e2a1369fc5 done
Copying blob c672c6903747 done
Copying blob c7c38e3c39ad done
Copying blob 01597d537f57 done
DEBU[0005] exporting opaque data as blob "sha256:a981c8992512d65c9b450a9ecabb1cb9d35bb6b03f3640f86471032d5800d825"
DEBU[0005] No compression detected
DEBU[0005] Compression change for blob sha256:a981c8992512d65c9b450a9ecabb1cb9d35bb6b03f3640f86471032d5800d825 ("application/vnd.docker.container.image.v1+json") not supported
DEBU[0005] Using original blob without modification
Copying config a981c89925 done
Writing manifest to image destination
Storing signatures
DEBU[0005] Called push.PersistentPostRunE(./podman push --compression-format=gzip --compress --log-level debug httpd dir:/tmp1)
Describe the results you received
no compression action,
Describe the results you expected
compression should be done according to the format gzip or zest
podman info output
Podman in a container
Yes
Privileged Or Rootless
None
Upstream Latest Release
Yes
Additional environment details
Additional environment details
Additional information
Additional information like issue happens only occasionally or issue happens with a particular architecture or on a particular setting
The text was updated successfully, but these errors were encountered: