Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beautify #2467

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Beautify #2467

merged 3 commits into from
Jul 11, 2024

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Jun 27, 2024

Some parts come from #1147, some are just vaguely related.

Should not change behavior.

See individual commit messages for details.

@rhatdan
Copy link
Member

rhatdan commented Jul 1, 2024

/approve
/lgtm

@mtrmac mtrmac force-pushed the eautify branch 3 times, most recently from 1c81438 to 597d314 Compare July 6, 2024 14:26
The compiler is smart enough that referencing
a local variable is not any faster than len(srcInfos).

If anything, keeping the extra variable might add to register pressure
because the compiler might not understand that the srcInfos change due to
LayerInfosForCopy does not change the number of layers.

Should not change behavior.

Signed-off-by: Miloslav Trmač <[email protected]>
Should not change behavior.

Signed-off-by: Miloslav Trmač <[email protected]>
Otherwise "err" refers to a variable outside of this closure,
not even to the one used by the immediate caller.

Should not change behavior.

Signed-off-by: Miloslav Trmač <[email protected]>
@rhatdan rhatdan merged commit 7ce6348 into containers:main Jul 11, 2024
10 checks passed
@mtrmac mtrmac deleted the eautify branch July 11, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants