Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman-remote checkpoint/restore tests: failing #12334

Closed
edsantiago opened this issue Nov 17, 2021 · 4 comments · Fixed by #12342
Closed

podman-remote checkpoint/restore tests: failing #12334

edsantiago opened this issue Nov 17, 2021 · 4 comments · Fixed by #12342
Assignees
@vrothberg
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote

Comments

@edsantiago
Copy link
Member

Tests failing. Almost certainly related to #12281. Failure seems to be here https://github.com/containers/podman/blob/f5e509ce098074cbb4c468b9d443f46e6c7770ed/test/e2e/checkpoint_test.go#L917
@edsantiago edsantiago added the remote Problem is in podman-remote label Nov 17, 2021
This was referenced Nov 17, 2021
Closed
Merged
@edsantiago
Copy link
Member Author

@containers/podman-maintainers looks like I missed @vrothberg, and he's OOTO tomorrow. Can anyone look into this please? It is blocking #11795.

@vrothberg
Copy link
Member

I will have a look but I guess that something else must have merged after #12281 and broken it. #12281 was clearly green (and passed locally).

@vrothberg
Copy link
Member

Correction: I suspect that the tests are now executed with runc, and those break. I can reproduce locally. I still have 40 minutes until the course and will hurry to pull something together.

@vrothberg vrothberg mentioned this issue Nov 18, 2021
Merged
@vrothberg
Copy link
Member

Here's a PR: #12342

vrothberg added a commit to vrothberg/libpod that referenced this issue Nov 18, 2021
@vrothberg
remote checkpoint/restore: more fixes
fceecc3 
* Support `checkpoint --pre-checkpoint`

* Support `checkpoint --with-previous`

* Disable `restore --import-previous` for the remote client since we had
  to send two files which in turn would require to tar them up and hence
  be a breaking change.  Podman 4.0 would be the chance and I hope we'll
  find time before that to remote-restore prettier.

Note that I did not run over swagger yet to check whether all parameters
are actually documented due to time constraints.

Fixes: containers#12334
Signed-off-by: Valentin Rothberg <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vrothberg vrothberg

Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remote checkpoint/restore: more fixes vrothberg/libpod
2 participants
@edsantiago @vrothberg