Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix remote checkpoint/restore #12281

Merged
merged 1 commit into from
Nov 17, 2021
Merged

fix remote checkpoint/restore #12281

merged 1 commit into from
Nov 17, 2021

Conversation

vrothberg
Copy link
Member

@vrothberg vrothberg commented Nov 12, 2021 •
edited
Loading

Nothing was working before, and it's too much to summarize. To make
sure we're not regressing in the future again, enable the remote e2e
tests.

Fixes: #12007
Signed-off-by: Valentin Rothberg [email protected]

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2021
@rhatdan
Copy link
Member

rhatdan commented Nov 12, 2021

LGTM

@TomSweeneyRedHat
Copy link
Member

Changes LGTM
but too much red in the tests still, unfortunately.

@mheon
Copy link
Member

mheon commented Nov 15, 2021

F34 and Ubuntu 21.10 root test failures look legitimate

@umohnani8
Copy link
Member

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2021
@mheon
Copy link
Member

mheon commented Nov 15, 2021

You have merge conflicts

@vrothberg
Copy link
Member Author

Ha, restore is broken as well -.-

@vrothberg
Copy link
Member Author

The amount of work to get this fixed shocks me.

@rhatdan
Copy link
Member

rhatdan commented Nov 16, 2021

Should we just drop support for remote checkpoint and restore. Not sure this should be a remote function.

@vrothberg
Copy link
Member Author

Should we just drop support for remote checkpoint and restore. Not sure this should be a remote function.

It has been broken since the v2 rewrite. The remote tests aren't yet exercised in CI, so we never noticed but I guess there are no users since there is no report.

But I almost got it working, so we can keep it I guess.

@vrothberg
fix remote checkpoint/restore
33ec8c6 
Nothing was working before, and it's too much to summarize.  To make
sure we're not regressing in the future again, enable the remote e2e
tests.

Fixes: containers#12007
Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg vrothberg changed the title fix remote checkpoint fix remote checkpoint/restore Nov 16, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2021
@vrothberg
Copy link
Member Author

Tests passed on my machine ✔️

@vrothberg
Copy link
Member Author

@containers/podman-maintainers PTAL

@rhatdan
Copy link
Member

rhatdan commented Nov 16, 2021

LGTM
@adrianreber PTAL

@vrothberg vrothberg mentioned this pull request Nov 17, 2021
Closed
@vrothberg
Copy link
Member Author

Note: once merged, we can close #12053.

@vrothberg
Copy link
Member Author

@giuseppe PTAL

@rhatdan
Copy link
Member

rhatdan commented Nov 17, 2021

/lgtm
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2021
@openshift-merge-robot openshift-merge-robot merged commit 85733e0 into containers:main Nov 17, 2021
@vrothberg vrothberg deleted the fix-12007 branch November 17, 2021 11:30
This was referenced Nov 17, 2021
Closed
Merged
Closed
Open
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rhatdan rhatdan

@umohnani8 umohnani8

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman-remote container restore: panic
6 participants
@vrothberg @rhatdan @TomSweeneyRedHat @mheon @umohnani8 @openshift-merge-robot