-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return of the Evil Dead Pprof #12624
Comments
I think it's time to have a closer look. Bumping the timeouts clearly does not help. 😢 |
A friendly reminder that this issue had no activity for 30 days. |
podman system service verify pprof endpoints [It] are not available
podman system service verify pprof endpoints [It] are available
|
A friendly reminder that this bug still exists podman system service verify pprof endpoints [It] are not available
|
podman system service verify pprof endpoints [It] are available
podman system service verify pprof endpoints [It] are not available
|
podman system service verify pprof endpoints [It] are available
podman system service verify pprof endpoints [It] are not available
|
Note for future: the flaking test was disabled by #13460. We are going to get monthly "friendly reminders" from github. KEEP THIS BUG OPEN. If you get tired of the friendly reminders, either fix the bug or completely remove the offending test (as in, remove the code entirely, don't just skip). |
A friendly reminder that this issue had no activity for 30 days. |
A friendly reminder that this issue had no activity for 30 days. |
A friendly reminder that this issue had no activity for 30 days. |
The tests are skipped so what point thus this serve? pprof are debugging endpoints only and given we survived without tests for over two years I would say remove the tests and close this one out, objections? |
The tests are skipped because of this flake. They've been skipped for over two years, and nobody has complained about pprof, so I'm okay removing the tests and closing this. @jwhonce, this is your code, any objection? |
Two tests are skipped for a long time because they flaked to much, nobody cares about them and there are only debugging endpoints mostly so it is not critical either. The "of 2 seconds" tests isn't useful either. It waits up to 30s for the exit so it doesn't actually verify a proper timeout. Additionally we have similar checks in the system tests "podman system service - CORS enabled in logs" so I consider this safe to remove. Fixes containers#12624 Signed-off-by: Paul Holzinger <[email protected]>
Two tests are skipped for a long time because they flaked to much, nobody cares about them and there are only debugging endpoints mostly so it is not critical either. The "of 2 seconds" tests isn't useful either. It waits up to 30s for the exit so it doesn't actually verify a proper timeout. Additionally we have similar checks in the system tests "podman system service - CORS enabled in logs" so I consider this safe to remove. Fixes containers#12624 Signed-off-by: Paul Holzinger <[email protected]>
Sorry, @vrothberg and @jwhonce. This one just won't die.
link
The text was updated successfully, but these errors were encountered: