Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return of the Evil Dead Pprof #12624

Closed
edsantiago opened this issue Dec 16, 2021 · 12 comments · Fixed by #23099
Closed

Return of the Evil Dead Pprof #12624

edsantiago opened this issue Dec 16, 2021 · 12 comments · Fixed by #23099
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

Sorry, @vrothberg and @jwhonce. This one just won't die.

         • Failure [24.380 seconds]
         podman system service
         /var/tmp/go/src/github.com/containers/podman/test/e2e/system_service_test.go:18
           verify pprof endpoints
           /var/tmp/go/src/github.com/containers/podman/test/e2e/system_service_test.go:56
             are available [It]
             /var/tmp/go/src/github.com/containers/podman/test/e2e/system_service_test.go:60
         
             Timed out after 20.001s.
             Expected process to exit.  It did not.

link

@vrothberg
Copy link
Member

I think it's time to have a closer look. Bumping the timeouts clearly does not help.

😢

@Luap99 Luap99 added the flakes Flakes from Continuous Integration label Dec 16, 2021
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@edsantiago
Copy link
Member Author

podman system service verify pprof endpoints [It] are not available

podman system service verify pprof endpoints [It] are available

@edsantiago
Copy link
Member Author

A friendly reminder that this bug still exists

podman system service verify pprof endpoints [It] are not available

@edsantiago
Copy link
Member Author

podman system service verify pprof endpoints [It] are available

podman system service verify pprof endpoints [It] are not available

@kousu
Copy link
Contributor

kousu commented Mar 1, 2022

podman system service verify pprof endpoints [It] are available

podman system service verify pprof endpoints [It] are not available

@edsantiago
Copy link
Member Author

Note for future: the flaking test was disabled by #13460.

We are going to get monthly "friendly reminders" from github. KEEP THIS BUG OPEN. If you get tired of the friendly reminders, either fix the bug or completely remove the offending test (as in, remove the code entirely, don't just skip).

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

A friendly reminder that this issue had no activity for 30 days.

@github-actions
Copy link

github-actions bot commented May 9, 2022

A friendly reminder that this issue had no activity for 30 days.

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

A friendly reminder that this issue had no activity for 30 days.

@Luap99
Copy link
Member

Luap99 commented Jun 25, 2024

The tests are skipped so what point thus this serve? pprof are debugging endpoints only and given we survived without tests for over two years I would say remove the tests and close this one out, objections?

@edsantiago
Copy link
Member Author

The tests are skipped because of this flake. They've been skipped for over two years, and nobody has complained about pprof, so I'm okay removing the tests and closing this. @jwhonce, this is your code, any objection?

Luap99 added a commit to Luap99/libpod that referenced this issue Jun 25, 2024
Two tests are skipped for a long time because they flaked to much,
nobody cares about them and there are only debugging endpoints mostly so
it is not critical either.

The "of 2 seconds" tests isn't useful either. It waits up to 30s for the
exit so it doesn't actually verify a proper timeout. Additionally we
have similar checks in the system tests "podman system service -
CORS enabled in logs" so I consider this safe to remove.

Fixes containers#12624

Signed-off-by: Paul Holzinger <[email protected]>
mheon pushed a commit to mheon/libpod that referenced this issue Jul 10, 2024
Two tests are skipped for a long time because they flaked to much,
nobody cares about them and there are only debugging endpoints mostly so
it is not critical either.

The "of 2 seconds" tests isn't useful either. It waits up to 30s for the
exit so it doesn't actually verify a proper timeout. Additionally we
have similar checks in the system tests "podman system service -
CORS enabled in logs" so I consider this safe to remove.

Fixes containers#12624

Signed-off-by: Paul Holzinger <[email protected]>
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants