Fix Container List API call to return mount info #12735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
rhatdan
force-pushed
the
mount
branch
2 times, most recently
from
54d6649
to
afbdf6f
Compare
|
Code LGTM, but your tests are red |
|
@edsantiago Any suggestion on how to test this? |
|
@rhatdan there are curl based tests for the apis in tests/apiv3 that could easily check this |
|
code LGTM |
|
@rhatdan by the time I looked at this (5 minutes after your email) you had done a force-push, and I see tests in this revision. The test doesn't actually work, it needs this change to work: - .[0].Mounts[0].Destination="/tmp" \
+ .[0].Mounts[0]="/tmp" \Is that your question? |
We are hard coding mounts to return nil in compat API, since we have the data, we should return it. Fixes: containers#12734 Signed-off-by: Daniel J Walsh <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are hard coding mounts to return nil in compat API,
since we have the data, we should return it.
Fixes: #12734
Signed-off-by: Daniel J Walsh [email protected]