-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VOLUME from Dockerfile is not overwritten #5219
Comments
I'll take this one |
Can you provide the name of the image being used in the examples here? I can't reproduce with Podman 1.8.0 trying to mount over an image volume in a custom-built image, so it might be specific to this image. |
Actually, just a |
Hey,
Don't have access to my terminal currently, but it was this image
https://hub.docker.com/layers/teamspeak/library/teamspeak/3.11.0/images/sha256-c6bc812dfa39c58ce35d8f742acee51fc33ab6509c1824d071be732b24a17875?context=explore
And you are right it included a trailing / in the volume. I added trailing
slashes in the `-v` parameter yesterday . No effect.
Matthew Heon <[email protected]> schrieb am So., 16. Feb. 2020,
01:25:
… Actually, just a podman inspect of the image would help a lot... My
initial suspicion is that there's something slightly different about this
volume mount (trailing / maybe? Something messing up our normal
comparison) and inspect should tell us that path
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5219>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACAKGFL5CI2PQ22WZ2JERLRDCBYHANCNFSM4KV45SKA>
.
|
#5222 to fix |
We use filepath.Clean() to remove trailing slashes to ensure that when we supercede image mounts with mounts from --volume and --mount, paths are consistent when we compare. Unfortunately, while we used the cleaned path for the destination in the mount, it was accidentally not used to index the maps that we use to identify what to supercede, so our comparisons might be thrown off by trailing slashes and similar. Fixes containers#5219 Signed-off-by: Matthew Heon <[email protected]>
Thank you for that quick fix! |
We use filepath.Clean() to remove trailing slashes to ensure that when we supercede image mounts with mounts from --volume and --mount, paths are consistent when we compare. Unfortunately, while we used the cleaned path for the destination in the mount, it was accidentally not used to index the maps that we use to identify what to supercede, so our comparisons might be thrown off by trailing slashes and similar. Fixes containers#5219 Signed-off-by: Matthew Heon <[email protected]>
Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
I want to run the official teamspeak image. I want to overwrite the data directory with a directory of my own. Neither
-v
nor--mount
will overwrite theVOLUME
from the Dockerfile. Podman run will always create a volume. I do not run podman rootless.Steps to reproduce the issue:
Using
-v
produces the same resultDescribe the results you received:
Only the directory
/var/run/ts3server
is bind mounted to the host:Describe the results you expected:
I expected to both
/var/run/ts3server
and/var/ts3server
to be bind mounted to the hostAdditional information you deem important (e.g. issue happens only occasionally):
Output of
podman version
:Output of
podman info --debug
:Package info (e.g. output of
rpm -q podman
orapt list podman
):Additional environment details (AWS, VirtualBox, physical, etc.):
The box is a generic Hetzner Cloud VM.
Configuration of the podstack network:
The text was updated successfully, but these errors were encountered: