Use cleaned destination path for indexing image volumes

[mheon]

We use filepath.Clean() to remove trailing slashes to ensure that when we supercede image mounts with mounts from --volume and --mount, paths are consistent when we compare. Unfortunately, while we used the cleaned path for the destination in the mount, it was accidentally not used to index the maps that we use to identify what to supercede, so our comparisons might be thrown off by trailing slashes and similar.

Fixes #5219

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mheon]

I'll work on tests tomorrow, we'll need a new image to actually validate the fix. I think we'll have to build it.

[rhatdan]

LGTM
@baude @TomSweeneyRedHat @giuseppe @vrothberg @QiWang19 @jwhonce PTAL

[rhatdan]

@hikhvar PTAL

[mheon]

Added a test

[hikhvar]

It works for me:

bin/podman run --user 9987:9987  \
  --mount type=bind,src=/mnt/HC_Volume_4373159/teamspeak/data,target=/var/ts3server\
   -v /etc/teamspeak/:/var/run/ts3server/  \
   -p 9987:9987/udp \
   -e TS3SERVER_LICENSE=accept \
   --name teamspeak  \
   --network podstack  \
   --ip 10.90.0.5 \
   teamspeak:3.11.0

bin/podman inspect teampeak
[....]
        "Mounts": [
            {
                "Type": "bind",
                "Name": "",
                "Source": "/mnt/HC_Volume_4373159/teamspeak/data",
                "Destination": "/var/ts3server",
                "Driver": "",
                "Mode": "",
                "Options": [
                    "rbind"
                ],
                "RW": true,
                "Propagation": "rprivate"
            },
            {
                "Type": "bind",
                "Name": "",
                "Source": "/etc/teamspeak",
                "Destination": "/var/run/ts3server",
                "Driver": "",
                "Mode": "",
                "Options": [
                    "rbind"
                ],
                "RW": true,
                "Propagation": "rprivate"
            }
        ],
[....]

 bin/podman version
Version:            1.8.1-dev
RemoteAPI Version:  1
Go Version:         go1.10.4
Git Commit:         40fa7e99317a32046fec2442b61dc524f63e52cd
Built:              Thu Feb 20 21:17:37 2020
OS/Arch:            linux/amd64

[mheon]

Restarted tests, let's get this landed

[baude]

/lgtm