Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to v1.4.2-stable3 #4494

Merged
merged 3 commits into from
Nov 21, 2019
Merged

Conversation

mheon
Copy link
Member

@mheon mheon commented Nov 11, 2019

Backport #3363 and bump version

For docker scripting compatibility, allow for json-file logging when creating args for conmon. That way, when json-file is supported, that case can be easily removed.

Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S labels Nov 11, 2019
@mheon
Copy link
Member Author

mheon commented Nov 11, 2019

@cevich Poke - any idea what's going on here?

@cevich
Copy link
Member

cevich commented Nov 11, 2019

Error:

Error while loading tasks: FAILED_PRECONDITION: There is no task with name 'rootless_testing' and task 'build_cache_images' depends on it!!

Best guess is a problem in .cirrus.yml where the system is now doing validation not originally performed at the time of writing. Should be easy to fix...

@cevich
Copy link
Member

cevich commented Nov 11, 2019

#4496

@rhatdan
Copy link
Member

rhatdan commented Nov 21, 2019

LGTM, I am going to force merge this, so we can move forward.

@rhatdan rhatdan merged commit d6d5c4a into containers:v1.4.2-stable Nov 21, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants