Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirrus: Use branch-specific container image tag #4496

Merged

Conversation

cevich
Copy link
Member

@cevich cevich commented Nov 11, 2019

N/B: This is against the v1.4.2-stable branch, not master.

Signed-off-by: Chris Evich [email protected]

@mheon
Copy link
Member

mheon commented Nov 12, 2019

Uh-oh. Are we using the same test images for this branch as master? We can't drop OSTree in a stable stream, so we might need to re-add it to all the images until we no longer support a release with it.

@mheon
Copy link
Member

mheon commented Nov 12, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2019
@cevich
Copy link
Member Author

cevich commented Nov 12, 2019

Uh-oh. Are we using the same test images for this branch as master?

Yes, this is exactly the problem. So before we can fix it here (by adding branch-specific builds to quay) we need this (otherwise CI on master will break):

#4503

@mheon
Copy link
Member

mheon commented Nov 14, 2019

With #4503 landed I think this needs a rebase

@github-actions
Copy link

This pull request had no activity for 30 days. In the absence of activity or the "do-not-close" label, the pull request will be automatically closed within 7 days.

@rhatdan
Copy link
Member

rhatdan commented Dec 16, 2019

@cevich You still working on this one?

@cevich
Copy link
Member Author

cevich commented Dec 20, 2019

I think so, maybe. I'll peek at it next year 😄

@github-actions github-actions bot closed this Dec 28, 2019
@cevich cevich reopened this Jan 2, 2020
@cevich cevich changed the title Cirrus: Fix/Remove unnecessary tasks/deps Cirrus: Use branch-specific container image tag Jan 2, 2020
@cevich
Copy link
Member Author

cevich commented Jan 2, 2020

Update: Since the container-based tasks weren't running, meta never touched the VM images, causing them to be considered disused and pruned. This is bad, but hopefully not irrecoverable. Attempting to rebuild the VM images, then I'll manually mark them to be preserved.

@cevich cevich force-pushed the fix_cirrus_deps branch 2 times, most recently from 95aea3a to bdcd28a Compare January 10, 2020 18:01
@cevich cevich changed the title WIP: Cirrus: Use branch-specific container image tag Cirrus: Use branch-specific container image tag Feb 6, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2020
@cevich cevich changed the title Cirrus: Use branch-specific container image tag WIP: Cirrus: Use branch-specific container image tag Feb 6, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2020
@cevich cevich changed the title WIP: Cirrus: Use branch-specific container image tag Cirrus: Use branch-specific container image tag Feb 6, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2020
@cevich
Copy link
Member Author

cevich commented Feb 7, 2020

@mheon this PR seems to be failing on a bunch of podman & test issues I'm pretty sure we've fixed in master. Does that mean there is back-porting work to be done here and for RHEL?

@mheon
Copy link
Member

mheon commented Feb 7, 2020

Hm. Our ability to do that for non-critical bugs is somewhat limited. I don't know how much we can justify changing (and how much we actually want to - patching 1.0.x has become actively painful at this point)

@cevich
Copy link
Member Author

cevich commented Feb 7, 2020

for non-critical bugs is somewhat limited

Yep I understand on all accounts.

What about only updating ./test/ maybe? I can attempt that, just not sure if/how it will work. The other-side of the coin is needing to test some critical update, but have automation break 😖

@cevich
Copy link
Member Author

cevich commented Feb 7, 2020

Another idea: I can simply make all the CI tasks "optional" on this branch. They'll still run and report, just won't block anything.

@cevich
Copy link
Member Author

cevich commented Feb 7, 2020

@mheon okay, well it's kind of gray-green status now 😄 Good 'nuff?

@mheon
Copy link
Member

mheon commented Feb 7, 2020

Certainly better than how things were... We can work the rest later if we end up with further backport requests.

@cevich
Copy link
Member Author

cevich commented Feb 24, 2020

Okay, this is ready to go then.

@rhatdan
Copy link
Member

rhatdan commented Feb 25, 2020

This LGTM
But should we update the images now, they are looking a little old.

@cevich
Copy link
Member Author

cevich commented Feb 26, 2020

@rhatdan that's intentional: This is the v1.4.2-stable branch, so it SHOULD be running whatever was "current" at time of branching. Unless I'm misunderstanding something.

@mheon
Copy link
Member

mheon commented Feb 26, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2020
@openshift-merge-robot openshift-merge-robot merged commit 6cc5c69 into containers:v1.4.2-stable Feb 26, 2020
@cevich cevich deleted the fix_cirrus_deps branch June 30, 2021 18:12
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants