-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cirrus: Use branch-specific container image tag #4496
Cirrus: Use branch-specific container image tag #4496
Conversation
381a967
to
ea9644b
Compare
Uh-oh. Are we using the same test images for this branch as master? We can't drop OSTree in a stable stream, so we might need to re-add it to all the images until we no longer support a release with it. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ea9644b
to
377d089
Compare
Yes, this is exactly the problem. So before we can fix it here (by adding branch-specific builds to quay) we need this (otherwise CI on master will break): |
61f8788
to
bc5e663
Compare
With #4503 landed I think this needs a rebase |
This pull request had no activity for 30 days. In the absence of activity or the "do-not-close" label, the pull request will be automatically closed within 7 days. |
@cevich You still working on this one? |
I think so, maybe. I'll peek at it next year 😄 |
Signed-off-by: Chris Evich <[email protected]>
Signed-off-by: Chris Evich <[email protected]>
bc5e663
to
958268a
Compare
Update: Since the container-based tasks weren't running, meta never touched the VM images, causing them to be considered disused and pruned. This is bad, but hopefully not irrecoverable. Attempting to rebuild the VM images, then I'll manually mark them to be preserved. |
95aea3a
to
bdcd28a
Compare
6b23b1e
to
3dca992
Compare
Signed-off-by: Chris Evich <[email protected]>
Signed-off-by: Chris Evich <[email protected]>
3dca992
to
8337cb3
Compare
@mheon this PR seems to be failing on a bunch of podman & test issues I'm pretty sure we've fixed in master. Does that mean there is back-porting work to be done here and for RHEL? |
Hm. Our ability to do that for non-critical bugs is somewhat limited. I don't know how much we can justify changing (and how much we actually want to - patching 1.0.x has become actively painful at this point) |
Yep I understand on all accounts. What about only updating |
Another idea: I can simply make all the CI tasks "optional" on this branch. They'll still run and report, just won't block anything. |
Signed-off-by: Chris Evich <[email protected]>
533257a
to
9a50c1c
Compare
@mheon okay, well it's kind of gray-green status now 😄 Good 'nuff? |
Certainly better than how things were... We can work the rest later if we end up with further backport requests. |
Okay, this is ready to go then. |
This LGTM |
@rhatdan that's intentional: This is the |
/lgtm |
N/B: This is against the v1.4.2-stable branch, not master.
Signed-off-by: Chris Evich [email protected]