-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cirrus: Use branch-specific container tags #4503
Cirrus: Use branch-specific container tags #4503
Conversation
Automated building of container images is handled in quay.io based on changes in the master branch of this repository. However, as additional branches are made, the "latest" image (from master) diverges from their expectations. Fix this by using the branch-tagged images built by quay. For the near-term, this also implies quay.io will be configured to also build different images for each branch, and tag them appropriately. Long-term, image build automation should be combined with libpod automation - to avoid needing to maintain automation in multiple systems/locations. Signed-off-by: Chris Evich <[email protected]>
@mheon this is needed so automated branch-specific builds can be added for the other branches, and not break automation here (on master). |
/approve |
1 similar comment
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, cevich, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, cevich, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Automated building of container images is handled in quay.io based on
changes in the master branch of this repository. However, as additional
branches are made, the "latest" image (from master) diverges from their
expectations. Fix this by using the branch-tagged images built by quay.
For the near-term, this also implies quay.io will be configured to also
build different images for each branch, and tag them appropriately.
Long-term, image build automation should be combined with libpod
automation - to avoid needing to maintain automation in multiple
systems/locations.
Signed-off-by: Chris Evich [email protected]