This repository has been archived by the owner on Feb 15, 2019. It is now read-only.
fix problem with query params #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 8, 2017
timoreimann
reviewed
Aug 8, 2017
forward/fwd.go
Outdated
| @@ -318,9 +316,13 @@ func (f *websocketForwarder) copyRequest(req *http.Request, u *url.URL) (outReq | |||
| outReq.URL.Scheme = "ws" | |||
| } | |||
|
|
|||
| requestURI, err := url.ParseRequestURI(outReq.RequestURI) | |||
| if err == nil { | |||
There was a problem hiding this comment.
Can be merged with the previous line to scope requestURI to the if block.
There was a problem hiding this comment.
To follow the best practice of reducing variable scopes to the least minimum. Just like you wouldn't reach out for global variables unless you needed too.
| } | ||
| defer conn.Close() | ||
| c.Assert(r.URL.Query().Get("query"), Equals, "test") | ||
| for { |
There was a problem hiding this comment.
Are we busy-waiting here consuming lots of CPU possibly?
Is there a risk we never finish the for loop in case of a bug and have to wait until a timeout hits?
I'm lacking web-socket knowledge, so basically just uttering vague concerns.
There was a problem hiding this comment.
In fact, the ReadMessage block until a message is received or the connection is closed so, it will not consume CPU etc...
juliens
force-pushed
the
websocket-query-params
branch
from
b17f655
to
9ef894a
Compare
timoreimann
approved these changes
Aug 16, 2017
traefiker
force-pushed
the
websocket-query-params
branch
from
3ab2b48
to
59d6481
Compare
This was referenced Nov 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query params were encoded when call was made to the backend.
Related to traefik/traefik#1930