This repository has been archived by the owner on Feb 15, 2019. It is now read-only.
WebSocket use gorilla/websocket #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatur
suggested changes
Nov 16, 2017
forward/fwd.go
Outdated
| f.log.Debugf("vulcand/oxy/forward/websocket: Dialing insecure (non-tls) tcp connection to host %s", host) | ||
| targetConn, err = net.Dial("tcp", host) | ||
| dialer.TLSClientConfig = f.tlsClientConfig.Clone() | ||
| //WebSocket is only in http/1.1 |
There was a problem hiding this comment.
Could you please add a space after //
forward/fwd.go
Outdated
| return | ||
| } | ||
| underlyingConn, _, err := hijacker.Hijack() | ||
|
|
||
| //Only the targetConn choose to CheckOrigin or not |
There was a problem hiding this comment.
Could you please add a space after //
forward/fwd.go
Outdated
| go replicate(targetConn.UnderlyingConn(), underlyingConn.UnderlyingConn(), "backend", "client") | ||
|
|
||
| // Try to read the first message | ||
| t, msg, err := targetConn.ReadMessage() |
There was a problem hiding this comment.
Could you please rename t to msgType
forward/fwd.go
Outdated
| } | ||
|
|
||
| go replicate(underlyingConn.UnderlyingConn(), targetConn.UnderlyingConn(), "client", "backend") | ||
| <-errc | ||
| } | ||
|
|
||
| // copyRequest makes a copy of the specified request. |
There was a problem hiding this comment.
Could you please fix your comment // copyWebSocketRequest makes a copy of the specified web socket request
forward/fwd.go
Outdated
|
|
||
| outReq.Header = make(http.Header) | ||
| //gorilla websocket use this header to set the request.Host tested in checkSameOrigin |
There was a problem hiding this comment.
Could you please add space after //
forward/fwd_websocket_test.go
Outdated
|
|
||
| req.Write(conn) | ||
|
|
||
| //First request works with 400 |
There was a problem hiding this comment.
Could you please add a space after //
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to:
#17
#20
#21
#22
#26
#27
#28
#31