This repository has been archived by the owner on Feb 15, 2019. It is now read-only.
Transfer TLSConfig from roundtripper in websocket dialer #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilevauge
reviewed
Sep 6, 2017
| @@ -128,6 +128,7 @@ func New(setters ...optSetter) (*Forwarder, error) { | |||
| if f.httpForwarder.roundTripper == nil { | |||
| f.httpForwarder.roundTripper = http.DefaultTransport | |||
| } | |||
| f.websocketForwarder.TLSClientConfig = f.httpForwarder.roundTripper.(*http.Transport).TLSClientConfig | |||
There was a problem hiding this comment.
f.httpForwarder.roundTripper can be nil
EDIT: nope...
There was a problem hiding this comment.
http.DefaultTransport can be nil ?
There was a problem hiding this comment.
Sorry, read too quickly, I edited my comment just before you answered ^^
emilevauge
approved these changes
Sep 7, 2017
This was referenced Sep 8, 2017
This was referenced Nov 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to traefik/traefik#2017