Skip to content

Commit

Permalink
Merge pull request #163 from kingthorin/recheck-cond-fix
Browse files Browse the repository at this point in the history
Move bot signature outside of recheck text
  • Loading branch information
ibakshay authored Sep 26, 2024
2 parents 0fb6942 + 0230ea8 commit ec9e083
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 43 deletions.
45 changes: 4 additions & 41 deletions dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -700,8 +700,9 @@ function dco(signed, committerMap) {
text += ' You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).<br/>';
}
if (input.suggestRecheck() == 'true') {
text += '<sub>You can retrigger this bot by commenting **recheck** in this Pull Request. Posted by the ****DCO Assistant Lite bot****.</sub>';
text += '<sub>You can retrigger this bot by commenting **recheck** in this Pull Request. </sub>';
}
text += '<sub>Posted by the ****DCO Assistant Lite bot****.</sub>';
return text;
}
function cla(signed, committerMap) {
Expand Down Expand Up @@ -736,8 +737,9 @@ function cla(signed, committerMap) {
text += ' You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).<br/>';
}
if (input.suggestRecheck() == 'true') {
text += '<sub>You can retrigger this bot by commenting **recheck** in this Pull Request. Posted by the **CLA Assistant Lite bot**.</sub>';
text += '<sub>You can retrigger this bot by commenting **recheck** in this Pull Request. </sub>';
}
text += '<sub>Posted by the **CLA Assistant Lite bot**.</sub>';
return text;
}

Expand Down Expand Up @@ -1135,45 +1137,6 @@ function getPrSignComment() {
exports.getPrSignComment = getPrSignComment;


/***/ }),

/***/ 6718:
/***/ (function(__unused_webpack_module, exports, __nccwpck_require__) {

"use strict";

var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
if (k2 === undefined) k2 = k;
var desc = Object.getOwnPropertyDescriptor(m, k);
if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
desc = { enumerable: true, get: function() { return m[k]; } };
}
Object.defineProperty(o, k2, desc);
}) : (function(o, m, k, k2) {
if (k2 === undefined) k2 = k;
o[k2] = m[k];
}));
var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
Object.defineProperty(o, "default", { enumerable: true, value: v });
}) : function(o, v) {
o["default"] = v;
});
var __importStar = (this && this.__importStar) || function (mod) {
if (mod && mod.__esModule) return mod;
var result = {};
if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
__setModuleDefault(result, mod);
return result;
};
Object.defineProperty(exports, "__esModule", ({ value: true }));
exports.getPrSignComment = void 0;
const input = __importStar(__nccwpck_require__(3611));
function getPrSignComment() {
return input.getCustomPrSignComment() || "I have read the CLA Document and I hereby sign the CLA";
}
exports.getPrSignComment = getPrSignComment;


/***/ }),

/***/ 7351:
Expand Down
6 changes: 4 additions & 2 deletions src/pullrequest/pullRequestCommentContent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,9 @@ function dco(signed: boolean, committerMap: CommitterMap): string {
}

if (input.suggestRecheck() == 'true') {
text += '<sub>You can retrigger this bot by commenting **recheck** in this Pull Request. Posted by the ****DCO Assistant Lite bot****.</sub>'
text += '<sub>You can retrigger this bot by commenting **recheck** in this Pull Request. </sub>'
}
text += '<sub>Posted by the ****DCO Assistant Lite bot****.</sub>'
return text
}

Expand Down Expand Up @@ -96,7 +97,8 @@ function cla(signed: boolean, committerMap: CommitterMap): string {
}

if (input.suggestRecheck() == 'true') {
text += '<sub>You can retrigger this bot by commenting **recheck** in this Pull Request. Posted by the **CLA Assistant Lite bot**.</sub>'
text += '<sub>You can retrigger this bot by commenting **recheck** in this Pull Request. </sub>'
}
text += '<sub>Posted by the **CLA Assistant Lite bot**.</sub>'
return text
}

0 comments on commit ec9e083

Please sign in to comment.