Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bot signature outside of recheck text #163

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

kingthorin
Copy link
Contributor

Follow-up to:
#158 (comment)

@kingthorin
Copy link
Contributor Author

kingthorin commented Sep 23, 2024

Separate from this PR. Would it make sense to drop node 18 in the build matrix and add 22?
https://nodejs.org/en/about/previous-releases

matrix:
node-version: [18.x, 20.x]

@kingthorin
Copy link
Contributor Author

@ibakshay sorry I didn't catch this the first time around 🤦‍♂️

Copy link
Member

@ibakshay ibakshay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ibakshay ibakshay merged commit ec9e083 into contributor-assistant:master Sep 26, 2024
4 checks passed
@kingthorin kingthorin deleted the recheck-cond-fix branch September 26, 2024 10:41
@kingthorin
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants