-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: fix: update to latest Angular commit conventions #220
WIP: fix: update to latest Angular commit conventions #220
Conversation
@bcoe It's pretty hard to keep up-to-date with the angular convention without any help from the angular team. I was hoping to work with them on the specs. I think the specs should be centralised at https://conventionalcommits.org/ EG: they should probably hold discussions there, then change their docs. I tried to communicate with them multiple times but no luck. Any idea what would be the right channel to work with them? |
@stevemao I agree; I see no reason to move away from What do you think of this @marionebl, we could still continue to keep the angular format up-to-date in the corresponding repo, but standard-verison would officially be adhering to a different set of guidelines. |
... I could imagine landing this still to unblock folks ... but I would like to make an effort to diverge from the stricter angular guidelines. |
Edit: There is no immediate action required for unblocking from my point of view - I moved the I track everything related to this here: https://github.com/marionebl/commitlint/issues/146 @bcoe I'd be fine with ways forward that remove the current uncertainty about the exact conventions to use when talking "Angular" conventions. I can see the following ToDos:
Doing a "fork" and renaming seems to be the safest way forward. As I see it that actually happened silently when the Angular team did their changes in January. |
@marionebl this plan of action sounds wonderful (as always sorry for the slow reply, it's reached the point where I get dozens of issues opened on various open-source projects ever week; I'm trying to figure out a workflow that helps me keep up better). Any interest in taking point on this project (getting us over to A good place to reach me for coordinating work is this slack. |
@bcoe No worries/pressure it is your free time after all. :) I'll drive the needed changes and ping you via Slack if needed:
|
@marionebl I made you an owner of this org so you can merge/close PRs/issues etc. Thanks! |
Awesome plan. I prefer config-conventional but I’m fine with standard too. |
@stevemao Thank you :) |
@marionebl I've tried using
I guess the issue is that the sentence starts with a number which is causing a validation error.
How do you suggest to fix this? Should this be fixed in the config conventional? |
@satazor Please raise this issue at commitlint, seams to be a regression with |
@marionebl awesome work creating config-conventional 👍 |
@marionebl what would it take for us to dust this off and land it? |
cleaning up some old pull requests, please feel free to reopen this conversation if you're still interested in implementing this. @marionebl I would still love to see us move to a conventional commits preset; so please feel free to dust this off at any time. |
Related:
conventional-changelog/conventional-changelog#249
#219
Work in Progress until angular/angular#20537 is resolved.