Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: fix: update to latest Angular commit conventions #220

Closed
wants to merge 2 commits into from
Closed

WIP: fix: update to latest Angular commit conventions #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16c9cc3
fix: update to latest commit conventions
marionebl Nov 20, 2017
a2b882e
test: adapt tests to new commit format
marionebl Nov 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"infile": "CHANGELOG.md",
"message": "chore(release): %s",
"message": "build: release %s",
"firstRelease": false,
"sign": false,
"noVerify": false,
Expand Down
12 changes: 6 additions & 6 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,8 @@ describe('cli', function () {
var captured = shell.cat('gitcapture.log').stdout.split('\n').map(function (line) {
return line ? JSON.parse(line) : line
})
captured[captured.length - 3].should.deep.equal(['commit', '-S', 'CHANGELOG.md', 'package.json', '-m', 'chore(release): 1.0.1'])
captured[captured.length - 2].should.deep.equal(['tag', '-s', 'v1.0.1', '-m', 'chore(release): 1.0.1'])
captured[captured.length - 3].should.deep.equal(['commit', '-S', 'CHANGELOG.md', 'package.json', '-m', 'build: release 1.0.1'])
captured[captured.length - 2].should.deep.equal(['tag', '-s', 'v1.0.1', '-m', 'build: release 1.0.1'])

unmock()
})
Expand Down Expand Up @@ -523,9 +523,9 @@ describe('cli', function () {
execCli().code.should.equal(0)

// check last commit message
shell.exec('git log --oneline -n1').stdout.should.match(/chore\(release\): 1\.1\.0/)
shell.exec('git log --oneline -n1').stdout.should.match(/build: release 1\.1\.0/)
// check annotated tag message
shell.exec('git tag -l -n1 v1.1.0').stdout.should.match(/chore\(release\): 1\.1\.0/)
shell.exec('git tag -l -n1 v1.1.0').stdout.should.match(/build: release 1\.1\.0/)
})

it('appends line feed at end of package.json', function () {
Expand Down Expand Up @@ -647,9 +647,9 @@ describe('standard-version', function () {
require('./index')({silent: true})
.then(() => {
// check last commit message
shell.exec('git log --oneline -n1').stdout.should.match(/chore\(release\): 1\.1\.0/)
shell.exec('git log --oneline -n1').stdout.should.match(/build: release 1\.1\.0/)
// check annotated tag message
shell.exec('git tag -l -n1 v1.1.0').stdout.should.match(/chore\(release\): 1\.1\.0/)
shell.exec('git tag -l -n1 v1.1.0').stdout.should.match(/build: release 1\.1\.0/)
done()
})
})
Expand Down