updated webrtc lib to m75 #455

akilude · 2019-11-29T15:18:08Z

This is for #452

Steps i followed:

python build-webrtc.py --setup --ios ~/src/
cd ~/src/build_webrtc/webrtc/ios/src/
git checkout -b m75
python build-webrtc.py --build --ios ~/src/
Replaced the webrtc.framework in the plugin with the generated webrtc.framework folder

If you want to merge, please test.

Thanks.

hthetiot · 2019-11-30T20:24:36Z

Thank you very much @akilude
I will test that next week.

hthetiot · 2019-11-30T20:28:33Z

I'm not sure why the Travis build fail @akilude did you compile for x86 and armv7 ?

akilude · 2019-12-01T17:50:52Z

@hthetiot i followed the instructions in this link and built only for iOS.

It was compiled for ARM, ARM-64, x86 and x64

I built the release build, should i build the debug build instead?

hthetiot · 2019-12-02T10:34:09Z

No that perfect @akilude , I will check if we get any error caused by WebRTC.framework API change like #427

Did you successfully run on iOS on your side with this new WebRTC version?

akilude · 2019-12-05T12:49:55Z

I haven't run it yet, was busy, will run it in a day or two, sorry for the late reply @hthetiot

hthetiot · 2019-12-06T14:07:58Z

No worries @akilude we all busy, that already fantastic that you helping.
I think we will have to update some swift for M75 migration.

akilude · 2019-12-09T04:47:20Z

i tried the app, it's not compiling, i think its due to the swift changes that need to be made.

hthetiot · 2019-12-09T12:45:37Z

Yes that what I was suspecting, I will look when I have time, fell free to past Xcode error here.

panassidi · 2020-02-04T11:24:17Z

Can you update code with m75 framework?

hthetiot · 2020-02-04T23:34:48Z

@panassidi Sorry I dont have the bandwitht yet for that.
You can wait or if you want you can pay me to do it :)

panassidi · 2020-02-05T13:34:06Z

@panassidi Sorry I dont have the bandwitht yet for that.
You can wait or if you want you can pay me to do it :)

I compiled m75 but my app do not compile
I raplaced webrtc.framework folder

hthetiot · 2020-02-05T15:07:31Z

@panassidi yes that why this PR is still open, we need to update the Swift code it's not enough to replace the WebRTC.framework you need also to replace the WebRTC binary also.

If you can try to test that branch and try to compile you application using Xcode and provide the Xcode errors that may help this issue to get closed.

Note: you need to use the instructions on the issue description to compile WebRTC outside WebRTC will not work.

panassidi · 2020-02-05T16:56:14Z

This is the error from XCode:

/Users/dartagnan/Apps/JoConnectBeta/platforms/ios/JoConnectBeta/Plugins/cordova-plugin-iosrtc/PluginMediaStreamRenderer.swift:4:45: Use of undeclared type 'RTCEAGLVideoViewDelegate'
/Users/dartagnan/Apps/JoConnectBeta/platforms/ios/JoConnectBeta/Plugins/cordova-plugin-iosrtc/PluginMediaStreamRenderer.swift:76:29: Cannot assign value of type 'PluginMediaStreamRenderer' to type 'RTCVideoViewDelegate?'

I can read on plugin notes (cordova-plugin-iosRTC)

"Use clean WebRTC.framework build with x86 and arm support, remove debug patches.

Remove custom patches (RTCVideoFrame.h, RTCEAGLVideoView.h)

Import RTCMTLVideoView.h to fix Metal related crashes later.

How can I remove custom and debug patches?

panassidi · 2020-02-07T10:52:02Z

Here the errors from Xcode:

/Users/dartagnan/Apps/JoConnectBeta/platforms/ios/JoConnectBeta/Plugins/cordova-plugin-iosrtc/PluginMediaStreamRenderer.swift:4:45: Use of undeclared type 'RTCEAGLVideoViewDelegate'
/Users/dartagnan/Apps/JoConnectBeta/platforms/ios/JoConnectBeta/Plugins/cordova-plugin-iosrtc/PluginMediaStreamRenderer.swift:76:29: Cannot assign value of type 'PluginMediaStreamRenderer' to type 'RTCVideoViewDelegate?'

I can read on roject note (cordova-lugin-iosrtc)
"Use clean WebRTC.framework build with x86 and arm support, remove debug patches.

Remove custom patches (RTCVideoFrame.h, RTCEAGLVideoView.h)

How can I remove debug and custom patches?

hthetiot · 2020-02-08T14:04:19Z

Thank you @panassidi as I told you for now I don't have the time to handle this issue, however this PR goes in the right direction, I think #427

hthetiot · 2020-02-25T19:50:02Z

Pushed https://github.com/cordova-rtc/cordova-plugin-iosrtc/tree/task/m75 with master merged if you want to rebase @akilude

hthetiot · 2020-02-25T20:19:06Z

@akilude Can you merge akilude#1
This PR fix the m75 support in your PR (PR inception) :)

To test task/m75

cordova plugin remove cordova-plugin-iosrtc --verbose
cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/m75 --verbose
cordova platform remove ios --no-save
cordova platform add ios@latest --no-save

Test Capture

cc @panassidi

How can I remove debug and custom patches?

The only issue was to expose the missing RTCEAGLVideoViewDelegate via src/cordova-plugin-iosrtc-Bridging-Header.h, All I had to do was to understand the error and instead of patching WebRTC I used cordova-plugin-iosrtc-Bridging-Header.h to expose RTCEAGLVideoViewDelegate to Swift.
akilude@639873c

…eamId

…f RTCMediaStream.streamId

…reamTrack only if rtcMediaStream.streamId or rtcMediaStreamTrack.trackId start with 'janus' to fix PeerConnection.addStream|addTrack regression

…eam like addTrack

…o populate foundation, component, priority, type, address, ip, protocol, port, relatedAddress and relatedPort RTCIceCandidate values

…dging-Header.h

akilude · 2020-02-25T20:27:56Z

@hthetiot it's done, thank you.

hthetiot · 2020-02-25T20:33:35Z

@akilude let me know if your test work, with akilude/cordova-plugin-iosrtc@639873c change it mean we should not need to patch WebRTC on the next update.

akilude · 2020-02-26T05:09:02Z

Hi, @hthetiot , little busy with work, also will get an iphone to test a little later, so might take a day or two to test it.

hthetiot · 2020-02-26T10:18:11Z

No problem @akilude

akilude · 2020-03-02T05:01:52Z

Hi @hthetiot , It works!

updated webrtc lib to m75

93cab57

hthetiot added this to the 7.0.x milestone Nov 30, 2019

hthetiot assigned akilude Nov 30, 2019

hthetiot added build enhancement libwebrtc labels Nov 30, 2019

hthetiot self-requested a review November 30, 2019 20:25

hthetiot and others added 6 commits February 26, 2020 01:56

Remove Remove the iOS platform and add it again to avoid confusion

daebff7

Update Building.md

b34827b

Update Building.md

3485097

Update ios_arch.js script link

dfb9bce

Update cordova plugin path

6e9b206

disable sudo gem install cocoapods that cause travis build to fail

d8eba21

hthetiot added 18 commits February 26, 2020 01:56

suffix PluginMediaStream.id with real RTCMediaStream.streamId

216d16f

suffix PluginMediaStreamTrack.id with real PluginMediaStreamTrack.str…

e693a27

…eamId

fix PeerConnection removestream to use PluginMediaStream.id instead o…

93b0e59

…f RTCMediaStream.streamId

prepare 6.0.6

af805e8

fix readOnly dispatchEvent event.target issue

93cbd1e

update extra/renderer-and-libwebrtc-tests.js to work on existing page

39b9b58

update dist/cordova-plugin-iosrtc.js with dispatchEvent fix

65405f5

prepare 6.0.7

086826c

add MediaStream_init debug

30b0da8

use UUID().uuidString preffix for PluginMediaStream and PluginMediaSt…

a9dd2f3

…reamTrack only if rtcMediaStream.streamId or rtcMediaStreamTrack.trackId start with 'janus' to fix PeerConnection.addStream|addTrack regression

use UUID().uuidString preffix for PluginMediaStream and PluginMediaSt…

a35ded0

…reamTrack only if rtcMediaStream.streamId or rtcMediaStreamTrack.trackId start with 'janus' to fix PeerConnection.addStream|addTrack regression

prevent webrtc-adapter to override RTCPeerConnection.prototype.addStr…

f59b5bb

…eam like addTrack

implement candidateToJson SDP candidate parser into RTCIceCandidate t…

b9ae97a

…o populate foundation, component, priority, type, address, ip, protocol, port, relatedAddress and relatedPort RTCIceCandidate values

build dist/cordova-plugin-iosrtc.js

c958f3e

Add Known Issues > iOS >= 13.3.1 Device support to README.md

df5c7a6

prepare 6.0.8

6f34dfd

build dist/cordova-plugin-iosrtc.js for 6.0.8

6ee8ed3

add missing RTCEAGLVideoViewDelegate to src/cordova-plugin-iosrtc-Bri…

2d4a292

…dging-Header.h

Merge branch 'master' into m75

8a2063e

This was referenced Feb 25, 2020

[Announcement] cordova-plugin-iosrtc Version 6.x.x notes #425

Closed

[Announcement] cordova-plugin-iosrtc Version 7.0.x notes #469

Closed

hthetiot approved these changes Feb 26, 2020

View reviewed changes

hthetiot changed the base branch from master to task/7.0.0 March 2, 2020 11:21

hthetiot merged commit e0e3805 into cordova-rtc:task/7.0.0 Mar 2, 2020

hthetiot mentioned this pull request Mar 2, 2020

update WebRTC.framework to M79 #475

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updated webrtc lib to m75 #455

updated webrtc lib to m75 #455

akilude commented Nov 29, 2019 •

edited

Loading

hthetiot commented Nov 30, 2019

hthetiot commented Nov 30, 2019

akilude commented Dec 1, 2019

hthetiot commented Dec 2, 2019

akilude commented Dec 5, 2019

hthetiot commented Dec 6, 2019

akilude commented Dec 9, 2019

hthetiot commented Dec 9, 2019

panassidi commented Feb 4, 2020

hthetiot commented Feb 4, 2020

panassidi commented Feb 5, 2020 •

edited

Loading

hthetiot commented Feb 5, 2020 •

edited

Loading

panassidi commented Feb 5, 2020

panassidi commented Feb 7, 2020

hthetiot commented Feb 8, 2020

hthetiot commented Feb 25, 2020

hthetiot commented Feb 25, 2020 •

edited

Loading

akilude commented Feb 25, 2020

hthetiot commented Feb 25, 2020

akilude commented Feb 26, 2020

hthetiot commented Feb 26, 2020

akilude commented Mar 2, 2020 •

edited

Loading

updated webrtc lib to m75 #455

updated webrtc lib to m75 #455

Conversation

akilude commented Nov 29, 2019 • edited Loading

hthetiot commented Nov 30, 2019

hthetiot commented Nov 30, 2019

akilude commented Dec 1, 2019

hthetiot commented Dec 2, 2019

akilude commented Dec 5, 2019

hthetiot commented Dec 6, 2019

akilude commented Dec 9, 2019

hthetiot commented Dec 9, 2019

panassidi commented Feb 4, 2020

hthetiot commented Feb 4, 2020

panassidi commented Feb 5, 2020 • edited Loading

hthetiot commented Feb 5, 2020 • edited Loading

panassidi commented Feb 5, 2020

panassidi commented Feb 7, 2020

hthetiot commented Feb 8, 2020

hthetiot commented Feb 25, 2020

hthetiot commented Feb 25, 2020 • edited Loading

To test task/m75

Test Capture

akilude commented Feb 25, 2020

hthetiot commented Feb 25, 2020

akilude commented Feb 26, 2020

hthetiot commented Feb 26, 2020

akilude commented Mar 2, 2020 • edited Loading

akilude commented Nov 29, 2019 •

edited

Loading

panassidi commented Feb 5, 2020 •

edited

Loading

hthetiot commented Feb 5, 2020 •

edited

Loading

hthetiot commented Feb 25, 2020 •

edited

Loading

akilude commented Mar 2, 2020 •

edited

Loading