Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rhcos-4.15] tests/kola: use FCOS defined fedora-archive.repo to set up containers #3141

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

marmijo
Copy link
Member

@marmijo marmijo commented Sep 4, 2024

This is a backport of: #3061

  • 4853041 (tests/ntp: use the FCOS defined fedora.repo to set up container)
  • b9f3487 (tests/podman/rootless-systemd: use the FCOS defined fedora.repo to set up container)

There are two tests that use the fedora container to set up and run the test environment. Use the fedora.repo file defined in fedora-coreos-config to set up that container. This will force packages to be downloaded from dl.fedoraproject.org, as specified in the FCOS file. The ITUP cluster, being used by the RHCOS pipeline, requires all outbound connections to be specified in a Firewall Egress file, and this will ensure the same connection will always be used.


This is also a backport of #3146

The fedora-archive.repo file now contains both EOL and non-EOL repo locations[1]. This means we can change the two kola tests that use the fedora container to use fedora-archive.repo as the only repo configuration file. This reduces the maintenance burden because now we don't have to change this curl statement when fedora versions reach EOL.

marmijo and others added 2 commits September 4, 2024 16:55
Use the fedora.repo file defined in fedora-coreos-config to set up the
container. This will force packages to be downloaded from
dl.fedoraproject.org, as specified in the FCOS file. The ITUP cluster,
being used by the RHCOS pipeline, requires all outbound connections
to be specified in a Firewall Egress file, and this will ensure the
same connection will always be used.

Co-authored-by: Aashish Radhakrishnan <[email protected]>
…t up container

Use the fedora.repo file defined in fedora-coreos-config to set up the
container. This will force packages to be downloaded from
dl.fedoraproject.org, as specified in the FCOS file. The ITUP cluster,
being used by the RHCOS pipeline, requires all outbound connections
to be specified in a Firewall Egress file, and this will ensure the
same connection will always be used.

Co-authored-by: Aashish Radhakrishnan <[email protected]>
@marmijo
Copy link
Member Author

marmijo commented Sep 5, 2024

/hold
I'll rework this PR to include #3146, which resulted from #3145

The `fedora-archive.repo` file now contains both EOL and non-EOL repo
locations[1]. This means we can change the two kola tests that use the
fedora container to use `fedora-archive.repo` as the only repo
configuration file. This reduces the maintenance burden because now we
don't have to change this curl statement when fedora versions reach EOL.

[1] coreos#3145
@marmijo marmijo changed the title [rhcos-4.15] tests/kola: use FCOS defined fedora.repo to set up containers [rhcos-4.15] tests/kola: use FCOS defined fedora-archive.repo to set up containers Sep 5, 2024
@marmijo
Copy link
Member Author

marmijo commented Sep 5, 2024

/unhold
this is ready for review

@marmijo marmijo removed the hold label Sep 5, 2024
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marmijo marmijo merged commit 2799de0 into coreos:rhcos-4.15 Sep 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants