-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fedora-archive.repo: use both EOL and non-EOL locations #3145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include both the EOL and non-EOL repo locations in the baseurl list to simplify maintenance. This update benefits two kola tests and the RHCOS extensions container by simplifying the repo configuration into a single file. As Fedora versions used by those containers reach EOL, we wont have to remove and replace the `fedora.repo` file. Instead, we can just use this file for container setup.
dustymabe
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
marmijo
added a commit
to marmijo/fedora-coreos-config
that referenced
this pull request
Sep 5, 2024
The `fedora-archive.repo` file now contains both EOL and non-EOL repo locations[1]. This means we can change the two kola tests that use the fedora container to use `fedora-archive.repo` as the only repo configuration file. This reduces the maintenance burden because now we don't have to change this curl statement when fedora versions reach EOL. [1] coreos#3145
This was referenced Sep 5, 2024
marmijo
added a commit
that referenced
this pull request
Sep 5, 2024
The `fedora-archive.repo` file now contains both EOL and non-EOL repo locations[1]. This means we can change the two kola tests that use the fedora container to use `fedora-archive.repo` as the only repo configuration file. This reduces the maintenance burden because now we don't have to change this curl statement when fedora versions reach EOL. [1] #3145
marmijo
added a commit
to marmijo/fedora-coreos-config
that referenced
this pull request
Sep 5, 2024
The `fedora-archive.repo` file now contains both EOL and non-EOL repo locations[1]. This means we can change the two kola tests that use the fedora container to use `fedora-archive.repo` as the only repo configuration file. This reduces the maintenance burden because now we don't have to change this curl statement when fedora versions reach EOL. [1] coreos#3145
marmijo
added a commit
to marmijo/fedora-coreos-config
that referenced
this pull request
Sep 5, 2024
The `fedora-archive.repo` file now contains both EOL and non-EOL repo locations[1]. This means we can change the two kola tests that use the fedora container to use `fedora-archive.repo` as the only repo configuration file. This reduces the maintenance burden because now we don't have to change this curl statement when fedora versions reach EOL. [1] coreos#3145
marmijo
added a commit
to marmijo/fedora-coreos-config
that referenced
this pull request
Sep 5, 2024
The `fedora-archive.repo` file now contains both EOL and non-EOL repo locations[1]. This means we can change the two kola tests that use the fedora container to use `fedora-archive.repo` as the only repo configuration file. This reduces the maintenance burden because now we don't have to change this curl statement when fedora versions reach EOL. [1] coreos#3145
marmijo
added a commit
that referenced
this pull request
Sep 6, 2024
The `fedora-archive.repo` file now contains both EOL and non-EOL repo locations[1]. This means we can change the two kola tests that use the fedora container to use `fedora-archive.repo` as the only repo configuration file. This reduces the maintenance burden because now we don't have to change this curl statement when fedora versions reach EOL. [1] #3145
marmijo
added a commit
that referenced
this pull request
Sep 6, 2024
The `fedora-archive.repo` file now contains both EOL and non-EOL repo locations[1]. This means we can change the two kola tests that use the fedora container to use `fedora-archive.repo` as the only repo configuration file. This reduces the maintenance burden because now we don't have to change this curl statement when fedora versions reach EOL. [1] #3145
marmijo
added a commit
that referenced
this pull request
Sep 6, 2024
The `fedora-archive.repo` file now contains both EOL and non-EOL repo locations[1]. This means we can change the two kola tests that use the fedora container to use `fedora-archive.repo` as the only repo configuration file. This reduces the maintenance burden because now we don't have to change this curl statement when fedora versions reach EOL. [1] #3145
marmijo
added a commit
to marmijo/os
that referenced
this pull request
Sep 6, 2024
The `fedora-archive.repo` file now contains both EOL and non-EOL repo locations[1]. This means we can change the extensions container, which uses the fedora container, to utilize `fedora-archive.repo` as the only repo configuration file. This reduces the maintenance burden because now we don't have to change this curl statement when fedora versions reach EOL. [1] coreos/fedora-coreos-config#3145
marmijo
added a commit
to marmijo/os
that referenced
this pull request
Sep 6, 2024
The `fedora-archive.repo` file now contains both EOL and non-EOL repo locations[1]. This means we can change the extensions container, which uses the fedora container, to utilize `fedora-archive.repo` as the only repo configuration file. This reduces the maintenance burden because now we don't have to change this curl statement when fedora versions reach EOL. [1] coreos/fedora-coreos-config#3145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include both the EOL and non-EOL repo locations in the baseurl list to simplify maintenance. This update benefits two kola tests and the RHCOS extensions container by simplifying the repo configuration into a single file. As Fedora versions used by those containers reach EOL, we wont have to remove and replace the
fedora.repo
file. Instead, we can just use this file for container setup.