-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeout on lifecycler heartbeat #6212
Conversation
71a2fdb
to
2256577
Compare
I think we can just add a context with timeout on the heartbeat call here? Lines 544 to 549 in f74b4cd
Something like:
This would make sure we always start a new heartbeat? Looking where the go routine got stuck, this would fix the problem: I think if we do that we dont need any extra flag at all and this would work for all kv client |
Signed-off-by: Anna Tran <[email protected]>
2256577
to
3041b3c
Compare
Signed-off-by: Anna Tran <[email protected]>
d4d2612
to
c6a3ca9
Compare
Looks good. Let's update the PR title and description based on the latest change. |
What this PR does:
Adds a timeout context to the lifecycler heartbeat to prevent requests to the ring from waiting indefinitely in case of a network issue.
Which issue(s) this PR fixes:
Fixes #6211
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]